KEP-5547: Add docs for Workload APIs integration with Job controller#54489
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
012aa63 to
732ee6a
Compare
andreyvelich
left a comment
There was a problem hiding this comment.
Thanks @helayoty, overall looks great!
| 1. Creates a `Workload` object in the same namespace with a `podGroupTemplate` | ||
| containing a gang policy where `minCount` equals the Job's parallelism. | ||
| 2. Creates a `PodGroup` object based on that template. | ||
| 3. Creates Pods with `spec.schedulingGroup.podGroupName` set to the `PodGroup` name, | ||
| linking each Pod to its scheduling group. |
There was a problem hiding this comment.
Can we also explain naming for Workload, PodGroupTemplate, and PodGroup ?
There was a problem hiding this comment.
I guess this should link to changes that are also in review #54490
|
/remove-area release-eng |
4696939 to
936f340
Compare
soltysh
left a comment
There was a problem hiding this comment.
Minor suggestions, but this lgtm from sig-apps pov
|
|
||
| {{< feature-state feature_gate_name="EnableWorkloadWithJob" >}} | ||
|
|
||
| When the [`EnableWorkloadWithJob`](/docs/reference/command-line-tools-reference/feature-gates/) feature gate is enabled, |
There was a problem hiding this comment.
If we land kubernetes/kubernetes#138210, this will need to get updated accordingly.
There was a problem hiding this comment.
Can we update this in a follow-up PR?
There was a problem hiding this comment.
@helayoty yes, this will definitely need to be updated in a follow-up PR once the the other lands, thanks (you can also create an issue for this as well, recommended)
|
PR needs rebase |
|
/milestone 1.36 |
Signed-off-by: Heba Elayoty <[email protected]> Signed-off-by: helayoty <[email protected]>
Signed-off-by: helayoty <[email protected]>
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 2891d613203060c374c47f7ca6317baf6e220437 |
|
good from docs, thanks |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natalisucks, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
EnableWorkloadWithJobis enabled/sig apps
/sig scheduling
/area workload-aware
Issue
Closes: #