KEP-4671, KEP-5598: Introducing Workload Aware Scheduling blog post#53012
KEP-4671, KEP-5598: Introducing Workload Aware Scheduling blog post#53012k8s-ci-robot merged 1 commit intokubernetes:mainfrom
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @macsko 👋 v1.35 Communications team here, @richabanker as author of #53030, I'd like you to be a writing buddy for @macsko on this PR. Please:
|
|
Hi @macsko 👋 -- this is Graziano (@graz-dev) from the v1.35 Communications Team! Just a friendly reminder that we are approaching the feature blog "ready for review" deadline: Friday 21st November. We ask you to have the blog in non-draft state, and all write-up to be complete, so that we can start the blog review from SIG Docs Blog team. If you have any questions or need help, please don't hesitate to reach out to me or any of the Communications Team members. We are here to help you! |
6d6529b to
fb9535d
Compare
graz-dev
left a comment
There was a problem hiding this comment.
Some nits, the overall article looks good and easy to read.
Thank you!
| ... | ||
| ``` | ||
|
|
||
| ## How Gang Scheduling Works |
There was a problem hiding this comment.
| ## How Gang Scheduling Works | |
| ## How gang scheduling works |
There was a problem hiding this comment.
Here would be useful to have an example of the behavior.
If you configure this way, and these conditions are met then this will happen...
There was a problem hiding this comment.
Do you mean modifying the current gang scheduling steps or adding a standalone example after the high level description?
There was a problem hiding this comment.
Adding a standalone example after the high level description.
| Note that you may need to review your kube-scheduler configuration | ||
| to ensure default topology spread constraints are not implicitly disabling batching for your workloads. | ||
|
|
||
| See the [docs](TODO) for more details about restrictions. |
There was a problem hiding this comment.
I presume we should wait for these to land in the dev-1.35 branch?
Exceptions are not hard to get, IMO (the deadline for blog articles is formally today).
There was a problem hiding this comment.
Yes, I think we can merge it as a draft if needed and then add the link to the doc later before publishing it.
|
/sig scheduling |
sanposhiho
left a comment
There was a problem hiding this comment.
/lgtm
technical side from sig-scheduling
|
LGTM label has been added. DetailsGit tree hash: 4a7a2a87710f5ce455e8c1765019d78fb5ccec1a |
|
Looks great, thank you @macsko! |
lmktfy
left a comment
There was a problem hiding this comment.
Great!
Happy to see this merge as a draft.
|
Oh, it's not passing CI checks. |
a9b9b29 to
69efb0d
Compare
69efb0d to
9323181
Compare
|
@lmktfy It now passed the CI checks |
|
/lgtm Thank you! |
|
LGTM label has been added. DetailsGit tree hash: 7b42b34a3b891e2cf06e15ca14592985092f5ecc |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: graz-dev, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR add a blog post Workload Aware Scheduling, containing kubernetes/enhancements#4671 and kubernetes/enhancements#5598 features.
Issue
Closes: #