Skip to content

Update docs for Pod Generation GA#52913

Merged
k8s-ci-robot merged 1 commit intokubernetes:dev-1.35from
natasha41575:pod-gen-ga
Nov 17, 2025
Merged

Update docs for Pod Generation GA#52913
k8s-ci-robot merged 1 commit intokubernetes:dev-1.35from
natasha41575:pod-gen-ga

Conversation

@natasha41575
Copy link
Copy Markdown
Contributor

@natasha41575 natasha41575 commented Oct 23, 2025 •
edited
Loading

Pod Generation graduated to GA

kubernetes/enhancements#5067

@k8s-ci-robot k8s-ci-robot added this to the 1.35 milestone Oct 23, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 23, 2025
@natasha41575 natasha41575 mentioned this pull request Oct 23, 2025
Closed
12 tasks
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 23, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit ca31812
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/69136033d9cfc10008198513

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 23, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ca31812
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/69136033af424a0008149427
😎 Deploy Preview https://deploy-preview-52913--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 10, 2025
@natasha41575 natasha41575 marked this pull request as ready for review November 10, 2025 16:25
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2025
@natasha41575
Copy link
Copy Markdown
Contributor Author

natasha41575 commented Nov 10, 2025

/assign @SergeyKanzhelev @tallclair

SergeyKanzhelev
SergeyKanzhelev reviewed Nov 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the mention of the FG in this sentence:

website/content/en/docs/concepts/workloads/pods/_index.md

Line 267 in 98bfafe

object. If the feature gate `PodObservedGenerationTracking` is set, the Kubelet will set `status.observedGeneration`

@SergeyKanzhelev
Copy link
Copy Markdown
Member

SergeyKanzhelev commented Nov 10, 2025

Also API field needs an update: https://github.com/kubernetes/kubernetes/blob/aceb89debc2632c5c9956c8b7ef591426a485447/staging/src/k8s.io/api/core/v1/generated.proto#L3921 No need to mention FG that is locked to default now.

I am ok doing it during code freeze, but API reviewers may not be around. Perhaps send a PR and see if we can make it thru in 1.35.

@natasha41575
Copy link
Copy Markdown
Contributor Author

natasha41575 commented Nov 10, 2025 •
edited
Loading

Also API field needs an update: https://github.com/kubernetes/kubernetes/blob/aceb89debc2632c5c9956c8b7ef591426a485447/staging/src/k8s.io/api/core/v1/generated.proto#L3921 No need to mention FG that is locked to default now.

I am ok doing it during code freeze, but API reviewers may not be around. Perhaps send a PR and see if we can make it thru in 1.35.

I had thought about updating the API field description with the GA-graduation PR but I wasn't sure about it (my thought was that the FG technically is still there?). Thanks for confirming though that we can update it to no longer mention it. I will try to do so tomorrow.

@natasha41575 natasha41575 mentioned this pull request Nov 11, 2025
Merged
@natasha41575
Copy link
Copy Markdown
Contributor Author

natasha41575 commented Nov 11, 2025

@SergeyKanzhelev both of your comments are addressed now

kubernetes/kubernetes#135256 for updating the api field description

SergeyKanzhelev
SergeyKanzhelev approved these changes Nov 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 12, 2025

LGTM label has been added.

DetailsGit tree hash: 0c9c2604172ac7890a91500bd21c0545adef28a7

@natasha41575
Copy link
Copy Markdown
Contributor Author

natasha41575 commented Nov 12, 2025

/assign sayakmukhopadhyay

@reylejano
Copy link
Copy Markdown
Member

reylejano commented Nov 17, 2025

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit 267e0fd into kubernetes:dev-1.35 Nov 17, 2025
6 checks passed
@natasha41575 natasha41575 deleted the pod-gen-ga branch November 17, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmktfy lmktfy Awaiting requested review from lmktfy

@reylejano reylejano Awaiting requested review from reylejano

1 more reviewer

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SergeyKanzhelev SergeyKanzhelev

@SayakMukhopadhyay SayakMukhopadhyay

@tallclair tallclair

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

1.35

Development

Successfully merging this pull request may close these issues.

6 participants

@natasha41575 @SergeyKanzhelev @k8s-ci-robot @reylejano @SayakMukhopadhyay @tallclair