Skip to content

4033: update to GA#51446

Merged
k8s-ci-robot merged 1 commit intokubernetes:dev-1.34from
haircommander:cgroup-cri-ga
Aug 6, 2025
Merged

4033: update to GA#51446
k8s-ci-robot merged 1 commit intokubernetes:dev-1.34from
haircommander:cgroup-cri-ga

Conversation

@haircommander
Copy link
Copy Markdown
Contributor

@haircommander haircommander commented Jun 30, 2025

Description

Issue

KEP kubernetes/enhancements#4033

Closes: #

@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Jun 30, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 30, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 50c9876
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/6892430714dba10008eff1da

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 30, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 30, 2025
@haircommander haircommander mentioned this pull request Jun 30, 2025
Closed
13 tasks
lmktfy
lmktfy reviewed Jul 1, 2025
View reviewed changes
Comment thread ...t/en/docs/reference/command-line-tools-reference/feature-gates/KubeletCgroupDriverFromCRI.md
Copy link
Copy Markdown
Member

@lmktfy lmktfy Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use this feature gate on nodes with a kubelet that supports the feature gate
and where there is a CRI container runtime that supports the RuntimeConfig
CRI call.

After graduation, this text will be stale. We should instead hyperlink to the docs about cgroups driver detection.

@lmktfy
Copy link
Copy Markdown
Member

lmktfy commented Jul 3, 2025

Could you rebase this against dev-1.34?

@haircommander
Copy link
Copy Markdown
Contributor Author

haircommander commented Jul 14, 2025

@lmktfy done!

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 14, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 50c9876
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68924307e81b4500081ef130
😎 Deploy Preview https://deploy-preview-51446--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@michellengnx
Copy link
Copy Markdown
Contributor

michellengnx commented Aug 2, 2025

Hello @haircommander 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Wednesday August 6, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you!

@michellengnx
Copy link
Copy Markdown
Contributor

michellengnx commented Aug 5, 2025

/assign @lmktfy @natalisucks

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2025
@haircommander
4033: update to GA
50c9876 
Signed-off-by: Peter Hunt <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 5, 2025
@rphillips
Copy link
Copy Markdown
Member

rphillips commented Aug 5, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 5, 2025

LGTM label has been added.

DetailsGit tree hash: c4a1c5fb0a3f8e43e8e4168f197e37d994466cb5

@natalisucks
Copy link
Copy Markdown
Contributor

natalisucks commented Aug 6, 2025

we use kubelet capitalized and not capitalized interchangably here, but it's not such an issue so as to miss the Docs Freeze deadline for this release. thanks @haircommander!
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natalisucks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5d1bdc7 into kubernetes:dev-1.34 Aug 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmktfy lmktfy lmktfy left review comments

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

Assignees

@rphillips rphillips

@natalisucks natalisucks

@lmktfy lmktfy

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

1.34

Development

Successfully merging this pull request may close these issues.

6 participants

@haircommander @lmktfy @michellengnx @rphillips @k8s-ci-robot @natalisucks