Add config API for kubelet stats v1alpha1#50394
Add config API for kubelet stats v1alpha1#50394tengqm wants to merge 1 commit intokubernetes:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
language/en
✅ Pull request preview available for checking
To edit notification comments on pull requests, go to your Netlify site configuration. |
| [kubelet configuration (v1beta1)](/docs/reference/config-api/kubelet-config.v1beta1/) | ||
| [kubelet configuration (v1)](/docs/reference/config-api/kubelet-config.v1/) | ||
| * [kubelet credential providers (v1)](/docs/reference/config-api/kubelet-credentialprovider.v1/) | ||
| * [kubelet stats (v1)](/docs/reference/config-api/kubelet-stats.v1/) |
| </td> | ||
| </tr> | ||
| </tbody> | ||
| </table> |
tengqm
force-pushed
the
add-kube-stats-api
branch
from
e8381a0 to
674ff5b
Compare
lmktfy
left a comment
lmktfy
left a comment
There was a problem hiding this comment.
This reference, whilst useful, doesn't look like a reference for a configuration file format.
I think it belongs within https://kubernetes.io/docs/reference/node/ or https://kubernetes.io/docs/reference/instrumentation/
(whichever one we pick, it'd be nice to have both those URLs link to the new reference).
@tengqm, what do you think? Do you agree that this isn't an application programming interface and isn't a configuration file format?
|
|
||
|
|
There was a problem hiding this comment.
I expected to see front matter here.
|
@lmktfy No. This is not an API for programming "configuration", but it is an API for parsing the kubelet |
|
I don't like the idea of calling this an application programming interface. It's an interface but not b really one you invoke from code. I appreciate that we (Kubernetes) currently use the term "API" in our configuration file formats, but I worry about the risk of confusing readers. I remember the first time I encountered the Kubernetes docs and, back then, I felt they were so poor that I couldn't make sense of Kubernetes. My concern has that kind of newbie reader and their interests at heart. |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
No description provided.