KEP-4205: update for alpha release in 1.33#49895
KEP-4205: update for alpha release in 1.33#49895k8s-ci-robot merged 1 commit intokubernetes:dev-1.33from
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hello @haircommander 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th March 2025 18:00 PDT. Thank you! |
|
Hi @rayandas, I've updated the PR with the documentation content. This PR is ready for review. PTAL. @haircommander Could you update the state of the PR from |
|
LGTM! |
|
Hello @roycaihw 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 8th April, 2025 18:00 PDT. |
|
|
||
| {{< feature-state for_k8s_version="v1.33" state="alpha" >}} | ||
|
|
||
| As an alpha feature, Kubernetes lets you configure Kubelet to collect Linux kernel [Pressure Stall Information](https://docs.kernel.org/accounting/psi.html) |
There was a problem hiding this comment.
Should we mention any requirements on kernel for this?
There was a problem hiding this comment.
Good point! I added kernel version requirement to the docs.
|
/lgtm One nit but it is not blocking. Technical review is complete on this @Urvashi0109! |
|
LGTM label has been added. DetailsGit tree hash: 28ea715784c8a3c0b231281ecebe0b27b028def8 |
|
@Princesso @RainbowMango Could you help review this PR? Thank you! |
| As an alpha feature, Kubernetes lets you configure Kubelet to collect Linux kernel [Pressure Stall Information](https://docs.kernel.org/accounting/psi.html) | ||
| (PSI) for CPU, memory and IO usage. The information is collected at node, pod and container level. The metrics are exposed at the `/metrics/cadvisor` endpoint with the following names: |
There was a problem hiding this comment.
Please wrap these long lines as we do for other paragraphs.
See sembr.org for the suggested line breaking style.
| As an alpha feature, Kubernetes lets you configure Kubelet to collect Linux kernel [Pressure Stall Information](https://docs.kernel.org/accounting/psi.html) | |
| (PSI) for CPU, memory and IO usage. The information is collected at node, pod and container level. The metrics are exposed at the `/metrics/cadvisor` endpoint with the following names: | |
| As an alpha feature, Kubernetes lets you configure Kubelet to collect Linux kernel | |
| [Pressure Stall Information](https://docs.kernel.org/accounting/psi.html)(PSI) | |
| for CPU, memory and I/O usage. | |
| The information is collected at node, pod and container level. | |
| The metrics are exposed at the `/metrics/cadvisor` endpoint with the following names: |
| container_pressure_io_waiting_seconds_total | ||
| ``` | ||
|
|
||
| You must enable the `KubeletPSI` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) to use this feature. The information is also exposed in the [Summary API](/docs/reference/instrumentation/node-metrics#psi). |
There was a problem hiding this comment.
| You must enable the `KubeletPSI` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) to use this feature. The information is also exposed in the [Summary API](/docs/reference/instrumentation/node-metrics#psi). | |
| You must enable the `KubeletPSI` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) | |
| to use this feature. The information is also exposed in the | |
| [Summary API](/docs/reference/instrumentation/node-metrics#psi). |
| defaultValue: false | ||
| fromVersion: "1.33" | ||
| --- | ||
| Enable Kubelet to surface Pressure Stall Information (PSI) metrics in the Summary API and Prometheus metrics. |
There was a problem hiding this comment.
We don't write "Kubelet", we write "kubelet".
|
|
||
| {{< feature-state for_k8s_version="v1.33" state="alpha" >}} | ||
|
|
||
| As an alpha feature, Kubernetes lets you configure Kubelet to collect Linux kernel [Pressure Stall Information](https://docs.kernel.org/accounting/psi.html) (PSI) for CPU, memory and IO usage. The information is collected at node, pod and container level. See [Summary API](https://github.com/kubernetes/kubernetes/blob/ef838fcc3fa3b43c2e67b4e43d71b6720fc61898/staging/src/k8s.io/kubelet/pkg/apis/stats/v1alpha1/types.go#L281-L300) for detailed schema. You must enable the `KubeletPSI` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) to use this feature. The information is also exposed in [Prometheus metrics](/docs/concepts/cluster-administration/system-metrics#psi-metrics). |
There was a problem hiding this comment.
- Break the long "lines".
- Avoid pointing users to the Go source code for the Summary API. We can add a config API reference for this.
There was a problem hiding this comment.
Done. I switched the Go source code link with https://pkg.go.dev/k8s.io/kubelet/pkg/apis/stats/v1alpha1. PTAL
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Giving an |
|
LGTM label has been added. DetailsGit tree hash: 606c3d968671cc530395cdfea208967f3812b331 |
Description
Issue
Closes: #