image version hash should depend on all files that trigger cloud build#49624
Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom Feb 3, 2025
Merged
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
SayakMukhopadhyay
changed the title
k8s-ci-robot
added
the
sig/docs
k8s-ci-robot
added
the
size/XS
Member
Author
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
Member
Author
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sftim
reviewed
Feb 3, 2025
Contributor
sftim
left a comment
sftim
left a comment
There was a problem hiding this comment.
Not a change to the live site, so I can LGTM and approve this.
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: 0acbaeac0444bfc8690982b653fe1aaba1d3e201 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
Contributor
|
/hold cancel All good, was just checking something. |
k8s-ci-robot
removed
the
do-not-merge/hold
Contributor
|
Great for having identified the root cause 🙌🏻 @SayakMukhopadhyay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds all the files that trigger the cloud container build to the image tag hash.
It also plays a secondary role in trying to fix #49460 once and for all since the couldbuild didn't trigger on merging #49610. This issue depends on kubernetes/test-infra#34253 so it will be on hold until that PR gets merged. Feel free to unhold it once that happens.