Skip to content

fix: use docsy dependency without hugo-extended#49610

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
SayakMukhopadhyay:container-build-fix
Feb 1, 2025
Merged

fix: use docsy dependency without hugo-extended#49610
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
SayakMukhopadhyay:container-build-fix

Conversation

@SayakMukhopadhyay
Copy link
Copy Markdown
Member

@SayakMukhopadhyay SayakMukhopadhyay commented Jan 31, 2025

Description

This PR changes the docsy dependency to the 0.6.x branch of Docsy which removed hugo-extended from its dependencies. This ensures that hugo-extended is not installed.

Issue

Closes: #49460

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 31, 2025
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 31, 2025

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f1e8412
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/679d1618dbb5e50008c606ee
😎 Deploy Preview https://deploy-preview-49610--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nate-double-u
Copy link
Copy Markdown
Contributor

nate-double-u commented Jan 31, 2025

Testing on a macbook running sequoia by pulling a fresh copy of the repo and checking out this PR.

Local build ✅

npm install
make module-init
make serve

Container build ✅

npm install
make module-init
make container-build
make container-serve

This also solves the api-ref-generator dance issue I've been having 😊

Thanks for this @SayakMukhopadhyay!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 31, 2025

LGTM label has been added.

DetailsGit tree hash: 6934a18cb1dbaba22588ab42634f6731716ab666

Arhell
Arhell reviewed Feb 1, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sftim
sftim reviewed Feb 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit 907dfe9 into kubernetes:main Feb 1, 2025
@sftim
Copy link
Copy Markdown
Contributor

sftim commented Feb 2, 2025

Merged, but didn't fix #49460

@SayakMukhopadhyay SayakMukhopadhyay deleted the container-build-fix branch February 3, 2025 06:15
@SayakMukhopadhyay SayakMukhopadhyay mentioned this pull request Feb 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natalisucks natalisucks Awaiting requested review from natalisucks

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

2 more reviewers

@sftim sftim sftim left review comments

@Arhell Arhell Arhell left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nate-double-u nate-double-u

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't run website in a container via make container-serve due to the image absence

5 participants

@SayakMukhopadhyay @nate-double-u @k8s-ci-robot @sftim @Arhell