✅ Pull request preview available for checking

Name	Link
🔨 Latest commit	30b92ff
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67570039ac9a3d00088ef4c8
😎 Deploy Preview	https://deploy-preview-48812--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Try running mv node_modules node_modules_moved_aside before trying a local preview in a container. That should show up the snags, if there are any.

Hope this is OK
/retitle [WIP] Upgrade to Docsy 0.5.1 via NPM module

@sftim wrote via #48811 (comment):

You won't like this @chalin but the <i class="fa fa-icon-circle fa-fw"></i> was a bodge to get a correctly-indented second line with no icon.

That's the original presentation intent, so bear that in mind when considering what we'd like to preserve…

Yes, here's the fix I propose: a65258e. It looks like this:

which you can see via https://deploy-preview-48812--kubernetes-io-main-staging.netlify.app/docs/concepts/windows/.

Hope this is OK /retitle [WIP] Upgrade to Docsy 0.5.1 via NPM module

@sftim - with the latest changes, this is ready for reivew -- and so not WIP. The Docker & build script issues being orthogonal to the Docsy upgrade.

If this breaks local previewing in a container, we can't merge it.

Anyway, based on #48812 (comment)

/retitle Upgrade to Docsy 0.5.1 via NPM module

If this breaks local previewing in a container, we can't merge it.

@sftim - no, the simple change to the Docker file in this PR does not introduce any further breakages to local containerized build that might not have been there before.

Thanks @Okabe-Junya.
All: anything further to be done here? I'd like to move on to the next Docsy upgrade steps. Thanks!

If you don't run npm first, the effect of this PR is to break container previewing (you never previously had to run npm).

Error: command error: failed to load modules: module "docsy" not found in "/src/node_modules/docsy"; either add it as a Hugo Module or store it in "/src/node_modules".: module does not exist

Try running mv node_modules node_modules_moved_aside before trying a local preview in a container. That should show up the snags, if there are any.

@sftim - oh, you're right! Sorry for having missed that earlier. I'm looking into a solution.

Let's totally squash it on merge (I recommend that for all our projects). I was just hoping to keep the individual commits in this PR's branch history.

Noted, but this project prefers to preserve commits from the PR.

Before said squash, the final commit is / was d8392cc.

@sftim - PR rebased and squashed to 1 commit.

Before said squash, the final commit is / was d8392cc.

Is this a way to keep access to the commit history before the squash? Does GitHub keep all intermediate commits even after they've been overwritten by a force-pushed? (If so, that's good to know!)

(you can fetch a commit directly from GitHub, but possibly it may eventually get garbage collected)

I'm able to build from a fresh install both locally and using a container, but in both cases I need to do a pushd api-ref-generator && git fetch --unshallow && popd in order to get make module-init to work before things build. (I actually have do do make module-init twice, otherwise things aren't ready for the git fetch.)

reapplying lgtm

/lgtm

LGTM label has been added.

/hold

To make life easier, do not merge or unhold this until Kubernetes v1.32 is released. OK to unhold afterwards.

/hold cancel

/approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

/remove-label tide/merge-method-squash