✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	d06130c
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/677fc37deb5c0c00083b2469
😎 Deploy Preview	https://deploy-preview-48724--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

LGTM label has been added.

New changes are detected. LGTM label has been removed.

Hmm, I think this needs a new approach.
/close

I hope to get time to revisit it.

@sftim: Closed this PR.

Hmm. Not sure that https://deploy-preview-48724--kubernetes-io-main-staging.netlify.app/docs/contribute/style/diagram-guide/#example-2-ingress is rendering right after my changes.

It appears to be rendering properly now:

What appears off to you?

@sftim - can you also fix content/zh-cn/docs/contribute/style/diagram-guide.md by changing ```mermaid to ```text, since it requires the same fix as the English page: https://deploy-preview-48724--kubernetes-io-main-staging.netlify.app/zh-cn/docs/contribute/style/diagram-guide/#%E7%A4%BA%E4%BE%8B-2-ingress

I was going to check with the Chinese localization team about how they want to cover this.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chalin, lhajouji, salaxander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Btw, my previous LGTM of this PR is for the minimal changes it introduced in support of bumping up the version of Docsy to 0.6.x -- this is done is in the "minimalist" spirit of #44002. In particular, the Docsy 0.6.x Mermaid enhancements are not being integrated here. I'm assuming that this will be done later in scope of #41171.

We're all for minimal useful changes and small reviewable PRs.

After this merges, let's try to tidy up our use of Mermaid and align it to what upstream Docsy recommends.

@sftim @nate-double-u - does make container-image work for you?

Yes, it does (going through the same submodule management process I had to go through for your earlier PR (#48812))

make module-init # this will throw an error

pushd api-ref-generator && git fetch --unshallow && popd

make module-init # this will work now we've done the full clone

make container-image

make container-serve

A few points and nits

1. Do we need to set text blocks as ```text ? Just keeping ``` should be enough. But I can understand if its for verbosity.

Hmm. Not sure that https://deploy-preview-48724--kubernetes-io-main-staging.netlify.app/docs/contribute/style/diagram-guide/#example-2-ingress is rendering right after my changes.

2. @sftim The mermaid blocks were not rendering for me, either in container or in a local build. I got the following error
   

Failed to find a valid digest in the 'integrity' attribute for resource 'http://localhost:1313/js/mermaid-10.6.1.min.js' with computed SHA-384 integrity 'toDgDinNQVuBBJdT9Q9AnvM4szGg0g7BSEy/yLPRkkQylpeePcz8Mx/JLOFf33o+'. The resource has been blocked.

It seems like the issue lies in

1. How was this working until now?
2. Why does the netlify deployment still work whereas locally the issue crops up.
3. Is it only happening on my system or is this reproducible?

Apart from this I have this related question (#48724 (comment)) but otherwise the PR is fine.

I think the Mermaid part might need more work. That's a shame. C'est la vie.

I think the Mermaid part might need more work. That's a shame. C'est la vie.

You can get the mermaid to work by changing the integrity hash in the mermaid library that is getting imported. At least until we remove the shortcode and convert all mermaid diagrams to use code fencing.

@SayakMukhopadhyay if you'd like to, you're very welcome to take over this PR - feel free to make your own local branch and cherry pick any useful commit from this one.

I've more K8s WIP than I've capacity to look after; I've been leading on the Docsy upgrade partly because at the time nobody else was working on it. I get the sense you could easily get this one over the line; also, if you send in a PR and it looks good, I can LGTM it.

@SayakMukhopadhyay if you'd like to, you're very welcome to take over this PR - feel free to make your own local branch and cherry pick any useful commit from this one.

I've more K8s WIP than I've capacity to look after; I've been leading on the Docsy upgrade partly because at the time nobody else was working on it. I get the sense you could easily get this one over the line; also, if you send in a PR and it looks good, I can LGTM it.

Yeah, I can give it a go but I hope I am not stepping on any toes.

These toes are made for steppin'

Closing in favor of #49416

/close

@sftim: Closed this PR.

@sftim et all: why was this PR closed? It was a valid and fully functional update to Docsy 0.6.x, with Mermaid diagrams correctly rendering, ready to be merged.

It was also understood that any further Mermaid compatibility issues would be handled in a followup PR, as Tim wrote:

After this merges, let's try to tidy up our use of Mermaid and align it to what upstream Docsy recommends.

When I checked this, I wasn't seeing the Mermaid diagrams rendering correctly across all browsers; some pages did look OK in some browsers, but that wasn't enough for me to think it was good to merge. Also, I'm very happy for @SayakMukhopadhyay - or anyone else - to pick up the baton.

We need to at least not break Mermaid vs. the existing experience.

@sftim - can you also fix content/zh-cn/docs/contribute/style/diagram-guide.md by changing ```mermaid to ```text, since it requires the same fix as the English page: https://deploy-preview-48724--kubernetes-io-main-staging.netlify.app/zh-cn/docs/contribute/style/diagram-guide/#%E7%A4%BA%E4%BE%8B-2-ingress

Will follow through with:

• [zh-cn] Code-block language should be text in diagram-guide #49431

now that this PR has been closed.