Skip to content

Document pod level resources#48471

Merged
k8s-ci-robot merged 1 commit intokubernetes:dev-1.32from
ndixita:pod-resources-alpha
Nov 29, 2024
Merged

Document pod level resources#48471
k8s-ci-robot merged 1 commit intokubernetes:dev-1.32from
ndixita:pod-resources-alpha

Conversation

@ndixita
Copy link
Copy Markdown
Contributor

@ndixita ndixita commented Oct 21, 2024 •
edited by sftim
Loading

Description

Placeholder PR for documentation changes for Pod Level Resources Alpha

Issue

kubernetes/enhancements#2837

@k8s-ci-robot k8s-ci-robot added this to the 1.32 milestone Oct 21, 2024
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject area/localization General issues or PRs related to localization area/release-eng Issues or PRs related to the Release Engineering subproject area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes language/bn Issues or PRs related to Bengali language language/de Issues or PRs related to German language labels Oct 21, 2024
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/fr Issues or PRs related to French language language/hi Issues or PRs related to Hindi language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/pl Issues or PRs related to Polish language language/pt Issues or PRs related to Portuguese language labels Oct 21, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 21, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 0374213
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6749047ea880be0008323bbb

@k8s-ci-robot k8s-ci-robot added language/ru Issues or PRs related to Russian language language/uk Issues or PRs related to Ukrainian language language/vi Issues or PRs related to Vietnamese language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Oct 21, 2024
@ndixita ndixita force-pushed the pod-resources-alpha branch from 876023a to 74dcdef Compare October 21, 2024 17:18
@ndixita ndixita changed the title KEP 2837: draft PR for Pod Level Resources KEP KEP KEP 2837: draft PR for Pod Level Resources KEP Oct 21, 2024
@ndixita ndixita force-pushed the pod-resources-alpha branch from 5fbca82 to 19c2da5 Compare November 26, 2024 23:07
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2024
@ndixita ndixita force-pushed the pod-resources-alpha branch from 19c2da5 to 496bc15 Compare November 27, 2024 18:16
@ndixita ndixita changed the title [WIP] Document pod level resources Document pod level resources Nov 27, 2024
@ndixita
Copy link
Copy Markdown
Contributor Author

ndixita commented Nov 27, 2024

/assign @haircommander

haircommander
haircommander reviewed Nov 27, 2024
View reviewed changes
Comment thread content/en/docs/tasks/configure-pod-container/assign-pod-level-resources.md Outdated
@haircommander
Copy link
Copy Markdown
Contributor

haircommander commented Nov 27, 2024

This is a straightforward example of the work, well done on the time crunch @ndixita . in the future, I think we could add more detailed docs on the different interactions with OOM score/QoS class, but that's not in scope now I think

LGTM from tech perspective

@ndixita
Copy link
Copy Markdown
Contributor Author

ndixita commented Nov 27, 2024

This is a straightforward example of the work, well done on the time crunch @ndixita . in the future, I think we could add more detailed docs on the different interactions with OOM score/QoS class, but that's not in scope now I think

LGTM from tech perspective

I think I missed that we have to write the docs for alpha features. Noting it for next time to add the docs in time.

ramrodo
ramrodo reviewed Nov 28, 2024
View reviewed changes
Comment thread content/en/examples/pods/resource/pod-level-resources.yaml Outdated
ramrodo
ramrodo suggested changes Nov 28, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ramrodo ramrodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the pod-level-resources.yaml, in the containers section

ramrodo
ramrodo reviewed Nov 28, 2024
View reviewed changes
Comment thread content/en/examples/pods/resource/pod-level-resources.yaml Outdated
sftim
sftim reviewed Nov 28, 2024
View reviewed changes
Comment thread content/en/examples/pods/resource/pod-level-resources.yaml Outdated
sftim
sftim reviewed Nov 28, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sftim sftim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid that this PR doesn't look complete (even for an alpha feature).

I'd expect to see a change to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/ as well as to the Tasks section of the doc (to be clear: the Tasks part is already covered).

For alpha you don't need to write in depth, but the concept explanation of Pod resources does need to cover the option of specifying resource requests and limits at Pod level.

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Nov 28, 2024

/sig node

sftim
sftim reviewed Nov 28, 2024
View reviewed changes
Comment thread content/en/docs/tasks/configure-pod-container/assign-pod-level-resources.md Outdated
sftim
sftim reviewed Nov 28, 2024
View reviewed changes
Comment thread content/en/docs/tasks/configure-pod-container/assign-pod-level-resources.md Outdated
sftim
sftim reviewed Nov 28, 2024
View reviewed changes
Comment thread content/en/docs/tasks/configure-pod-container/assign-pod-level-resources.md Outdated
Comment thread content/en/docs/tasks/configure-pod-container/assign-pod-level-resources.md Outdated
Comment thread content/en/docs/tasks/configure-pod-container/assign-pod-level-resources.md
Comment thread content/en/docs/tasks/configure-pod-container/assign-pod-level-resources.md
@sftim
Copy link
Copy Markdown
Contributor

sftim commented Nov 28, 2024

Here's the key piece of feedback: #48471 (review)

I think if that gets covered, we can merge the PR and then plan some post-merge fixups.

@ndixita
Copy link
Copy Markdown
Contributor Author

ndixita commented Nov 28, 2024

This is a straightforward example of the work, well done on the time crunch @ndixita . in the future, I think we could add more detailed docs on the different interactions with OOM score/QoS class, but that's not in scope now I think

LGTM from tech perspective

@sftim this is where I have approvals from sig-node

@ndixita
Copy link
Copy Markdown
Contributor Author

ndixita commented Nov 28, 2024

Here's the key piece of feedback: #48471 (review)

I think if that gets covered, we can merge the PR and then plan some post-merge fixups.

Tried to address this. PTAL

sftim
sftim reviewed Nov 28, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've made suggestions that should mean we can merge this if you do another round of edits.

Comment thread content/en/docs/concepts/configuration/manage-resources-containers.md Outdated
Comment thread content/en/docs/concepts/configuration/manage-resources-containers.md Outdated
Comment thread content/en/docs/concepts/configuration/manage-resources-containers.md Outdated
Comment thread content/en/docs/concepts/configuration/manage-resources-containers.md Outdated
Comment thread content/en/docs/concepts/configuration/manage-resources-containers.md Outdated
Comment thread content/en/docs/concepts/configuration/manage-resources-containers.md Outdated
Comment thread content/en/docs/reference/command-line-tools-reference/feature-gates/pod-level-resources.md Outdated
Comment thread content/en/docs/tasks/configure-pod-container/assign-pod-level-resources.md
Comment thread content/en/docs/concepts/configuration/manage-resources-containers.md Outdated
@haircommander
Copy link
Copy Markdown
Contributor

haircommander commented Nov 29, 2024

still LGTM!

sftim
sftim reviewed Nov 29, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 29, 2024

LGTM label has been added.

DetailsGit tree hash: 82c26a92eb39483896e27796fe8aaf218eb6da99

@chanieljdan
Copy link
Copy Markdown
Contributor

chanieljdan commented Nov 29, 2024

Docs lgtm & tech lgtm noted

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chanieljdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Arhell Arhell Awaiting requested review from Arhell

@ariscahyadi ariscahyadi Awaiting requested review from ariscahyadi

4 more reviewers

@ramrodo ramrodo ramrodo requested changes

@haircommander haircommander haircommander left review comments

@iheartnathan iheartnathan iheartnathan left review comments

@sftim sftim sftim left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@haircommander haircommander

@sftim sftim

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

SIG Node: code and documentation PRs
Archived in project

Milestone

1.32

Development

Successfully merging this pull request may close these issues.

10 participants

@ndixita @utkarsh-singh1 @spurin @jihoon-seo @sftim @haircommander @k8s-ci-robot @chanieljdan @ramrodo @iheartnathan