KEP-4033: cgroup driver from CRI beta blog#47054
KEP-4033: cgroup driver from CRI beta blog#47054k8s-ci-robot merged 1 commit intokubernetes:mainfrom
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @haircommander thanks for your interest in contributing a blog for 1.31. Please update this to target the /hold Pending assignment of publication date (by release comms) We'll also keep this held until the v1.31 release has happened |
|
Hello! I'm Rashan, from the 1.31 Release comms team. I'm reaching out with a reminder that the blog ready for review deadline is July 26, 2024. Please let me know how we can help! |
|
Hello @haircommander today is our ready for review deadline for blog content for 1.31. Are you still interested in writing a blog for this feature? If so please let us know. This blog publication is scheduled for August 21. and this PR should target the cc: @rashansmith |
c119b13 to
6e6e556
Compare
|
Hello @haircommander, Is your blog ready for review? If so, please let us know. cc: @a-mccarthy |
|
yes this is ready! |
|
/hold cancel |
6e6e556 to
d2b585f
Compare
|
thanks @divya-mohan0209 updated |
divya-mohan0209
left a comment
There was a problem hiding this comment.
Thanks! Here's a second batch of comments. WDYT?
Would appreciate a second pair of eyes on this one and shall socialise on the sig docs blog channel.
| --- | ||
| layout: blog | ||
| title: "Configuring Kubernetes just got easier: cgroup driver from CRI" | ||
| date: 2024-08-06 |
There was a problem hiding this comment.
@a-mccarthy : Is this the correct date for publication? If not, please could you confirm what this needs to be?
There was a problem hiding this comment.
Per the filename, I'm guessing it should be 2024-08-21
There was a problem hiding this comment.
Per #47054 (comment)
| date: 2024-08-06 | |
| date: 2024-08-21 |
There was a problem hiding this comment.
Still hasn't been resolved in the commit visible to me. Please can we update it to the latest date?
There was a problem hiding this comment.
/approve cancel
to highlight the problem
|
|
||
| ## `KubeletCgroupDriverFromCRI` Feature Gate | ||
|
|
||
| In v1.28.0, the SIG Node community introduced the feature gate |
There was a problem hiding this comment.
| In v1.28.0, the SIG Node community introduced the feature gate | |
| In v1.28.0, the SIG Node community introduced the [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) |
| feature is now beta! | ||
|
|
||
| In addition to setting the feature gate, a cluster admin needs to ensure their | ||
| CRI implementatikn is new enough: |
There was a problem hiding this comment.
The current statement is likely to confuse users, as they might think they need to be on the latest version of the CRI for this to work. From the information given below, it would make more sense to say supported instead of new enough.
| CRI implementatikn is new enough: | |
| CRI implementation is new enough: |
I think that excluding your comments (I think they should be incorporated) it looks good! |
| @@ -0,0 +1,38 @@ | |||
| --- | |||
| layout: blog | |||
| title: "Configuring Kubernetes just got easier: cgroup driver from CRI" | |||
There was a problem hiding this comment.
Also, this needs to follow title casing per our style guide
There was a problem hiding this comment.
| title: "Configuring Kubernetes just got easier: cgroup driver from CRI" | |
| title: "Kubernetes v1.31: Autoconfiguration For Node Cgroup Driver (beta)" |
|
/lgtm |
| layout: blog | ||
| title: "Configuring Kubernetes just got easier: cgroup driver from CRI" | ||
| date: 2024-08-21 | ||
| slug: cgroup driver from CRI to beta |
There was a problem hiding this comment.
| slug: cgroup driver from CRI to beta | |
| slug: cri-cgroup-driver-lookup-now-beta |
| the same cgroup driver, or else the kubelet would exit with an error. This was a | ||
| source of headaches for many cluster admins. However, there is light at the end of the tunnel! | ||
|
|
||
| ## `KubeletCgroupDriverFromCRI` Feature Gate |
There was a problem hiding this comment.
| ## `KubeletCgroupDriverFromCRI` Feature Gate | |
| ## Automated CRI driver configuration |
or, less ideal
| ## `KubeletCgroupDriverFromCRI` Feature Gate | |
| ## `KubeletCgroupDriverFromCRI` feature gate |
| Then, they should ensure their CRI implementation is configured to the | ||
| `cgroup_driver` they would like to use. | ||
|
|
||
| ## Future Work |
There was a problem hiding this comment.
| ## Future Work | |
| ## Future work |
| - containerd: Support has been added in v2.0.0 | ||
| - CRI-O: Support has been added in v1.28.0 |
There was a problem hiding this comment.
| - containerd: Support has been added in v2.0.0 | |
| - CRI-O: Support has been added in v1.28.0 | |
| - containerd: Support was added in v2.0.0 | |
| - CRI-O: Support was added in v1.28.0 |
| @@ -0,0 +1,38 @@ | |||
| --- | |||
| layout: blog | |||
| title: "Configuring Kubernetes just got easier: cgroup driver from CRI" | |||
There was a problem hiding this comment.
| title: "Configuring Kubernetes just got easier: cgroup driver from CRI" | |
| title: "Kubernetes v1.31: Autoconfiguration For Node Cgroup Driver (beta)" |
39dcae8 to
3095156
Compare
|
updated thanks! |
3095156 to
8762893
Compare
Signed-off-by: Peter Hunt <[email protected]>
8762893 to
0bc5734
Compare
|
LGTM label has been added. DetailsGit tree hash: 3033422e01cc20ed4528525b99bd21a7600e5074 |
|
/hold cancel |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.