Welcome @aidanranney!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

@aidanranney 👋 Thanks for opening a pull request! In order for us to accept the PR, you'll need to sign the contributor license agreement.

Netlify is throwing a build error:

12:37:15 PM: ERROR 2020/05/10 19:37:15 Transformation failed: SCSS processing failed: file "stdin", line 6, col 1: File to import not found or unreadable: ../vendor/bootstrap/scss/bootstrap.

That's the error Hugo throws for a site version pre-0.60.0. We'll need to merge #19907 before this PR's preview builds successfully.

@jimangel @kbarnard10 @sftim @kbhawkey @onlydole

We'll need to merge #19907 before this PR's preview builds successfully.

I think we can tackle the couple obvious defects and maybe @bep could help with a conversation script.

If we get it passable along with majority of content legible, maybe we merge and open issues on top?

Would be a good convo for the weekly meeting.

Thanks @zacharysarah! I've passed the license agreement along to Troy to sign up the organization.

@aidanranney 👋 Please rebase when you have a chance. We merged the dependencies blocking this PR from building on its own merits.

The preview build for this PR still fails with the same error:

12:37:15 PM: ERROR 2020/05/10 19:37:15 Transformation failed: SCSS processing failed: file "stdin", line 6, col 1: File to import not found or unreadable: ../vendor/bootstrap/scss/bootstrap.

Eventually I figured out that netlify isn't loading the submodule properly. After some experimentation, I'm able to run the build locally. Here's how I did it:

In my local repo, I ran:

git remote add gearbox-built [email protected]:gearbox-built/website.git
git fetch --all
git checkout -b kubernetes-docsy gearbox-built/kubernetes-docsy
git rebase upstream/master

Then I ran:

git submodule update --init --recursive

The usual make serve works fine to instantiate a server locally.

TLDR: We need to add the --recursive flag into the build commands in netlify.toml.

@aidanranney I updated the PR description again; I hope that's OK.

/lgtm

#20874 (review) seems relevant and worth addressing at some point.

Hi @aidanranney . Here is what I found regarding the anchors on the page:
The anchors.js script (in theme) is looking for the headings under main:

var article = document.getElementsByTagName('main')[0];

However, /website/layouts/partials/announcement.html also has a main element.
I renamed the main tag in announcements.html to main_stuff.
The anchors script then creates the links.
I also fiddled a bit with /website/layouts/partials/head.html (updated jquery version).

Also, does the themes/docsy directory get created as part of this PR.
I worked with this branch, but the docsy dir was empty.

@kbhawkey

Also, does the themes/docsy directory get created as part of this PR. I worked with this branch, but the docsy dir was empty.

Makefile contains the git clone --init --recursive <whatever syntax> command to import the theme files.

Let's aim to merge this at 12pm Pacific on Monday, 15 June. (aka tomorrow)

@sftim Let's thread these PRs to merge shortly afterwards:

• Revise kubectl installation task #21719
• Revise descriptions for tasks #21752 (currently failing CI) Rebuilt, it looks fine now
• clean up in page toc #21779
• change main tag in announcement #21780
• Add blog post about docsy #21764

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Good work @aidanranney !