Skip to content

Conversation

@spiffxp
Copy link
Contributor

@spiffxp spiffxp commented Aug 10, 2018

ref: #8989

/cc @saad-ali
This will cooperate with the existing travis-ci stuff you have setup

/hold
For comment. Also not sure I want to deploy this on a Friday

@k8s-ci-robot k8s-ci-robot requested a review from saad-ali August 10, 2018 21:55
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/prow Issues or PRs related to prow approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2018
Copy link
Member

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment otherwise LGTM

external-provisioner:
required_status_checks:
contexts:
- continuous-integration/travis-ci
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I was looking at the repo settings, those contexts weren't yet listed as required for merge. I'd rather keep things exactly as they are, and then step away and let you make any further changes you'd like via PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. SGTM!

@saad-ali
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Contributor Author

spiffxp commented Aug 13, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2018
@spiffxp
Copy link
Contributor Author

spiffxp commented Aug 13, 2018

/retest
come on tide

@k8s-ci-robot k8s-ci-robot merged commit 8943b93 into kubernetes:master Aug 13, 2018
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the following 2 configmaps:

  • config configmap using the following files:
    • key config.yaml using file prow/config.yaml
  • plugins configmap using the following files:
    • key plugins.yaml using file prow/plugins.yaml
Details

In response to this:

ref: #8989

/cc @saad-ali
This will cooperate with the existing travis-ci stuff you have setup

/hold
For comment. Also not sure I want to deploy this on a Friday

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xing-yang
Copy link
Contributor

I have made "passing travis-ci required before merging" for https://github.com/kubernetes-csi/external-snapshotter. @saad-ali @spiffxp Can you please check and let me know if anything is missing? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants