-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Setup automation for kubernetes-csi #9014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also alphabetize orgs
Excluding kubernetes-csi/resources since that is supposedly going to be removed
saad-ali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment otherwise LGTM
| external-provisioner: | ||
| required_status_checks: | ||
| contexts: | ||
| - continuous-integration/travis-ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis CI is also enabled in these repos:
- https://github.com/kubernetes-csi/driver-registrar
- https://github.com/kubernetes-csi/external-snapshotter
- https://github.com/kubernetes-csi/livenessprobe
Not sure if they should also be specified here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I was looking at the repo settings, those contexts weren't yet listed as required for merge. I'd rather keep things exactly as they are, and then step away and let you make any further changes you'd like via PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. SGTM!
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saad-ali, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
/retest |
|
@spiffxp: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I have made "passing travis-ci required before merging" for https://github.com/kubernetes-csi/external-snapshotter. @saad-ali @spiffxp Can you please check and let me know if anything is missing? Thanks! |
ref: #8989
/cc @saad-ali
This will cooperate with the existing travis-ci stuff you have setup
/hold
For comment. Also not sure I want to deploy this on a Friday