Skip to content

Add package.json and package-lock.json to trigger condition#34253

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
SayakMukhopadhyay:sig-docs-package-json
Feb 3, 2025
Merged

Add package.json and package-lock.json to trigger condition#34253
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
SayakMukhopadhyay:sig-docs-package-json

Conversation

@SayakMukhopadhyay
Copy link
Copy Markdown
Member

@SayakMukhopadhyay SayakMukhopadhyay commented Feb 3, 2025

After the docs moved to using Docsy as an npm module, it became necessary that containers be created when the package.json and the associated lockfile gets changed. See kubernetes/website#48812

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 3, 2025
@SayakMukhopadhyay SayakMukhopadhyay mentioned this pull request Feb 3, 2025
Merged
timwangmusic
timwangmusic approved these changes Feb 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@timwangmusic timwangmusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SayakMukhopadhyay, timwangmusic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2018a4c into kubernetes:master Feb 3, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 3, 2025

@SayakMukhopadhyay: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8s-staging-sig-docs.yaml using file config/jobs/image-pushing/k8s-staging-sig-docs.yaml
Details

In response to this:

After the docs moved to using Docsy as an npm module, it became necessary that containers be created when the package.json and the associated lockfile gets changed. See kubernetes/website#48812

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SayakMukhopadhyay SayakMukhopadhyay deleted the sig-docs-package-json branch February 3, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims Awaiting requested review from dims

1 more reviewer

@timwangmusic timwangmusic timwangmusic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@timwangmusic timwangmusic

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SayakMukhopadhyay @k8s-ci-robot @timwangmusic