Skip to content

kube-cross: Update to go1.14.1#1208

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
justaugustus:kube-cross
Mar 23, 2020
Merged

kube-cross: Update to go1.14.1#1208
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
justaugustus:kube-cross

Conversation

@justaugustus
Copy link
Copy Markdown
Member

@justaugustus justaugustus commented Mar 23, 2020

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

go1.14.1 has been released. Here we update kube-cross appropriately.

build-image approvers:
/assign @BenTheElder @liggitt @cblecker @dims @listx

ref: kubernetes/kubernetes#88638, #1134

Does this PR introduce a user-facing change?

kube-cross: Update to go1.14.1

@justaugustus
kube-cross: Update to go1.14.1
fb21195 
Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 23, 2020

@justaugustus: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Details

Reasons for blocking this PR:

[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 23, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Mar 23, 2020
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 23, 2020
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 23, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2020
@justaugustus justaugustus removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Mar 23, 2020
This was referenced Mar 23, 2020
Merged
Closed
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Mar 23, 2020

/lgtm

what's with the blocked paths?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7fca2e9 into kubernetes:master Mar 23, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 23, 2020
@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Mar 23, 2020

@liggitt -- build in images/build/cross matches the blockade that was added to this repo due to the CI/shellcheck failures from v1.12.10, detailed in #816.

I'm planning to tie off any threads in that issue and fix up the blockade for 1.19.

This was referenced Mar 24, 2020
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@dims dims Awaiting requested review from dims

Assignees

@dims dims

@listx listx

@BenTheElder BenTheElder

@liggitt liggitt

@cblecker cblecker

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.19

Development

Successfully merging this pull request may close these issues.

7 participants

@justaugustus @k8s-ci-robot @liggitt @dims @listx @BenTheElder @cblecker