Skip to content

Automated cherry pick of #96716: Bump node-problem-detector to v0.8.5#96783

Merged
k8s-ci-robot merged 1 commit intokubernetes:release-1.17from
ialidzhikov:automated-cherry-pick-of-#96716-upstream-release-1.17
Nov 23, 2020
Merged

Automated cherry pick of #96716: Bump node-problem-detector to v0.8.5#96783
k8s-ci-robot merged 1 commit intokubernetes:release-1.17from
ialidzhikov:automated-cherry-pick-of-#96716-upstream-release-1.17

Conversation

@ialidzhikov
Copy link
Copy Markdown
Contributor

@ialidzhikov ialidzhikov commented Nov 21, 2020

Cherry pick of #96716 on release-1.17.

#96716: Bump node-problem-detector to v0.8.5

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 21, 2020
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 21, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 21, 2020

Hi @ialidzhikov. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/test labels Nov 21, 2020
@k8s-ci-robot k8s-ci-robot requested review from gmarek and mm4tt November 21, 2020 15:13
@k8s-ci-robot k8s-ci-robot added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 21, 2020
@ialidzhikov ialidzhikov mentioned this pull request Nov 21, 2020
Merged
@ialidzhikov
Copy link
Copy Markdown
Contributor Author

ialidzhikov commented Nov 21, 2020

/sig scalability
/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 21, 2020
@wojtek-t
Copy link
Copy Markdown
Member

wojtek-t commented Nov 23, 2020

/ok-to-test
/lgtm
/approve

@kubernetes/release-managers for cherrypick approval

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 23, 2020
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 23, 2020
@wojtek-t wojtek-t added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 23, 2020
@cpanato
Copy link
Copy Markdown
Member

cpanato commented Nov 23, 2020

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 23, 2020
cpanato
cpanato approved these changes Nov 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cpanato cpanato added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 23, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 23, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, ialidzhikov, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit edec69d into kubernetes:release-1.17 Nov 23, 2020
@ialidzhikov ialidzhikov deleted the automated-cherry-pick-of-#96716-upstream-release-1.17 branch January 9, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpanato cpanato cpanato approved these changes

@gmarek gmarek Awaiting requested review from gmarek

@mm4tt mm4tt Awaiting requested review from mm4tt

Assignees

@cpanato cpanato

@wojtek-t wojtek-t

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.17

Development

Successfully merging this pull request may close these issues.

5 participants

@ialidzhikov @k8s-ci-robot @wojtek-t @cpanato @tosi3k