Skip to content

add CAP_NET_RAW capability to CRI stats summery test#95321

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
harche:fix_cap
Oct 12, 2020
Merged

add CAP_NET_RAW capability to CRI stats summery test#95321
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
harche:fix_cap

Conversation

@harche
Copy link
Copy Markdown
Contributor

@harche harche commented Oct 6, 2020 •
edited by puerco
Loading

Signed-off-by: Harshal Patil [email protected]

What type of PR is this?

/kind failing-test

What this PR does / why we need it:
We need to set the capability CAP_NET_RAW at the test container level for the runtimes like CRIO, that do not add this by default.

Which issue(s) this PR fixes:

Fixes #95320

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 6, 2020

Hi @harche. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 6, 2020
@harche
Copy link
Copy Markdown
Contributor Author

harche commented Oct 6, 2020

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 6, 2020
@k8s-ci-robot k8s-ci-robot requested review from karan and resouer October 6, 2020 08:09
@karan
Copy link
Copy Markdown
Contributor

karan commented Oct 6, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2020
@harche
Copy link
Copy Markdown
Contributor Author

harche commented Oct 6, 2020

/test pull-kubernetes-e2e-gce-100-performance

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 6, 2020

@harche: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test pull-kubernetes-e2e-gce-100-performance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rphillips
Copy link
Copy Markdown
Member

rphillips commented Oct 6, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2020
@harche harche changed the title add CAP_NEW_RAW capability to CRI stats summery test add CAP_NET_RAW capability to CRI stats summery test Oct 6, 2020
@mrunalp
Copy link
Copy Markdown
Contributor

mrunalp commented Oct 6, 2020

/lgtm

@rphillips
Copy link
Copy Markdown
Member

rphillips commented Oct 8, 2020

/assign @sjenning

@sjenning
Copy link
Copy Markdown
Contributor

sjenning commented Oct 12, 2020

/triage accepted
/priority important-soon
/approve

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 12, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harche, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit 57a4653 into kubernetes:master Oct 12, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 12, 2020
This was referenced Oct 15, 2020
Closed
Merged
@mikebrow mikebrow mentioned this pull request Oct 16, 2020
Merged
@wilsonehusin
Copy link
Copy Markdown
Contributor

wilsonehusin commented Nov 21, 2020

👋 Release Notes 1.20 team here, this PR was marked with the release notes "No" instead of none at all (the right way to mark no release notes is to use NONE)

I'm going to try removing it for now 😄

/release-note-none

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 21, 2020

@wilsonehusin: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

Details

In response to this:

👋 Release Notes 1.20 team here, this PR was marked with the release notes "No" instead of none at all (the right way to mark no release notes is to use NONE)

I'm going to try removing it for now 😄

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karan karan Awaiting requested review from karan

@resouer resouer Awaiting requested review from resouer

Assignees

@mrunalp mrunalp

@sjenning sjenning

@karan karan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.20

Development

Successfully merging this pull request may close these issues.

Summary API [NodeConformance] test breaks on CRIO

7 participants

@harche @k8s-ci-robot @karan @rphillips @mrunalp @sjenning @wilsonehusin