Skip to content

remove pod presets#94090

Merged
k8s-ci-robot merged 4 commits intokubernetes:masterfrom
deads2k:podpreset
Sep 14, 2020
Merged

remove pod presets#94090
k8s-ci-robot merged 4 commits intokubernetes:masterfrom
deads2k:podpreset

Conversation

@deads2k
Copy link
Copy Markdown
Contributor

@deads2k deads2k commented Aug 18, 2020 •
edited by liggitt
Loading

fixes #93900

This has lingered since 1.single-digit. In keeping with not allowing permabeta and following the example of sig-auth removing alpha features that aren't graduating, this PR removes PodPresets.

/priority important-soon
/kind api

The v1alpha1 PodPreset API and admission plugin has been removed with no built-in replacement. Admission webhooks can be used to modify pods on creation.

@kubernetes/sig-service-catalog
@kubernetes/api-approvers

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 18, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 18, 2020

@deads2k: The label(s) kind/api cannot be applied, because the repository doesn't have them

Details

In response to this:

fixes #93900

This has lingered since 1.single-digit. In keeping with not allowing permabeta and following the example of sig-auth removing alpha features that aren't graduating, this PR removes PodPresets.

/priority important-soon
/kind api

PodPresets (alpha) are removed without a replacement.

@kubernetes/sig-service-catalog
@kubernetes/api-approvers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/apiserver area/kubectl area/provider/gcp Issues or PRs related to gcp provider area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Aug 18, 2020
@deads2k deads2k mentioned this pull request Aug 18, 2020
Closed
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 18, 2020
@k8s-ci-robot k8s-ci-robot requested review from SataQiu and mm4tt August 18, 2020 21:25
@liggitt liggitt mentioned this pull request Aug 18, 2020
Closed
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Aug 18, 2020

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@deads2k deads2k mentioned this pull request Aug 19, 2020
Merged
@dims
Copy link
Copy Markdown
Member

dims commented Aug 19, 2020

/cc

@k8s-ci-robot k8s-ci-robot requested a review from dims August 19, 2020 12:19
@liggitt liggitt self-assigned this Aug 19, 2020
@liggitt liggitt added this to the v1.20 milestone Aug 19, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2020
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Sep 14, 2020

/retest

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Sep 14, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 54df1fd into kubernetes:master Sep 14, 2020
@github-actions github-actions bot mentioned this pull request Sep 15, 2020
Open
alvaroaleman added a commit to alvaroaleman/test-infra that referenced this pull request Sep 15, 2020
@alvaroaleman
Remove comment referring to upstream PodPreset, they were removed
ea69abc 
Ref: kubernetes/kubernetes#94090
@alvaroaleman alvaroaleman mentioned this pull request Sep 15, 2020
Merged
@xmudrii xmudrii mentioned this pull request Sep 16, 2020
Closed
@chrkl chrkl mentioned this pull request Sep 16, 2020
Closed
@tengqm tengqm mentioned this pull request Sep 22, 2020
Closed
@cheftako cheftako mentioned this pull request Mar 15, 2021
Merged
@pacoxu pacoxu mentioned this pull request Apr 14, 2021
Closed
@pacoxu pacoxu mentioned this pull request Apr 23, 2021
Merged
@SataQiu SataQiu mentioned this pull request May 26, 2021
Merged
@cognifloyd cognifloyd mentioned this pull request Jul 6, 2021
Closed
@pacoxu pacoxu mentioned this pull request Jan 25, 2022
Closed
@EdDev EdDev mentioned this pull request Apr 6, 2022
Merged
lyarwood added a commit to lyarwood/kubevirt that referenced this pull request Jul 8, 2022
@lyarwood
Deprecate VirtualMachineInstancePresets
ed477c1 
VirtualMachineInstancePresets are based on the PodPresets k8s resource
and API that injected data into pods at creation time. However this API
never graduated from alpha and was removed in 1.20 [1]. While useful
there are some issues with the implementation that have resulted in
alternative approaches such as  VirtualMachineInstanceTypes and
VirtualMachinePreferences being made available within KubeVirt.

As per the CRD versioning docs this change updates the generated CRD
definition of VirtualMachineInstancePreset marking the currently
available versions of v1 and v1alpha3 as deprecated.

[1] kubernetes/kubernetes#94090
[2] https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#version-deprecation

Signed-off-by: Lee Yarwood <[email protected]>
@lyarwood lyarwood mentioned this pull request Jul 8, 2022
Merged
lyarwood added a commit to lyarwood/kubevirt that referenced this pull request Jul 11, 2022
@lyarwood
Deprecate VirtualMachineInstancePresets CRD
b63bdef 
VirtualMachineInstancePresets are based on the PodPresets k8s resource
and API that injected data into pods at creation time. However this API
never graduated from alpha and was removed in 1.20 [1]. While useful
there are some issues with the implementation that have resulted in
alternative approaches such as  VirtualMachineInstanceTypes and
VirtualMachinePreferences being made available within KubeVirt.

As per the CRD versioning docs this change updates the generated CRD
definition of VirtualMachineInstancePreset marking the currently
available versions of v1 and v1alpha3 as deprecated.

[1] kubernetes/kubernetes#94090
[2] https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#version-deprecation

Signed-off-by: Lee Yarwood <[email protected]>
lyarwood added a commit to lyarwood/kubevirt that referenced this pull request Jul 22, 2022
@lyarwood
Deprecate VirtualMachineInstancePresets CRD
8fc0f2f 
VirtualMachineInstancePresets are based on the PodPresets k8s resource
and API that injected data into pods at creation time. However this API
never graduated from alpha and was removed in 1.20 [1]. While useful
there are some issues with the implementation that have resulted in
alternative approaches such as  VirtualMachineInstanceTypes and
VirtualMachinePreferences being made available within KubeVirt.

As per the CRD versioning docs this change updates the generated CRD
definition of VirtualMachineInstancePreset marking the currently
available versions of v1 and v1alpha3 as deprecated.

[1] kubernetes/kubernetes#94090
[2] https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#version-deprecation

Signed-off-by: Lee Yarwood <[email protected]>
@liggitt liggitt mentioned this pull request Jan 6, 2023
Closed
@s-kawamura-w664 s-kawamura-w664 mentioned this pull request Mar 14, 2023
Merged
@earth429 earth429 mentioned this pull request Jun 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liggitt liggitt liggitt left review comments

@mm4tt mm4tt Awaiting requested review from mm4tt

@SataQiu SataQiu Awaiting requested review from SataQiu

@dims dims Awaiting requested review from dims

Assignees

@liggitt liggitt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubectl area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

API Reviews
Status: API review completed, 1.20

Milestone

v1.20

Development

Successfully merging this pull request may close these issues.

Pod Presets still in alpha since v1.6, time to remove it?

6 participants

@deads2k @k8s-ci-robot @fejta-bot @dims @liggitt @justaugustus