Skip to content

Update default etcd server to 3.4.9#92349

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
jingyih:update_etcd_server_3p4p9
Jul 17, 2020
Merged

Update default etcd server to 3.4.9#92349
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
jingyih:update_etcd_server_3p4p9

Conversation

@jingyih
Copy link
Copy Markdown
Contributor

@jingyih jingyih commented Jun 20, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
We updated etcd client version to 3.4.9 in #92075. We also updated Makefile for building etcd 3.4.9 images in #92078, which triggers automatic build [1]. This PR updates the default etcd server version to 3.4.9.

[1] https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/post-kubernetes-push-image-etcd/1273799163636617217

Which issue(s) this PR fixes:
Fixes #91266

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update default etcd server version to 3.4.9

/sig api-machinery
/area etcd

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. area/etcd cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 20, 2020
@jingyih jingyih mentioned this pull request Jun 20, 2020
Closed
4 tasks
@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jun 20, 2020

cc @BenTheElder @dims @wenjiaswe @kubernetes/release-engineering

@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jun 20, 2020 •
edited
Loading

/hold
until kubernetes/k8s.io#973 is merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2020
@k8s-ci-robot k8s-ci-robot requested review from sttts and zmerlynn June 20, 2020 20:04
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubeadm area/provider/gcp Issues or PRs related to gcp provider area/test sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 20, 2020
@saschagrunert
Copy link
Copy Markdown
Member

saschagrunert commented Jun 20, 2020

Hey, one question: with respect to the release note, what is the user facing change? Is kubeadm using the new etcd version?

Internal test and build environments do not count as “user facing”. 🙂

@BenTheElder
Copy link
Copy Markdown
Member

BenTheElder commented Jun 20, 2020 •
edited
Loading

/lgtm
/approve

Hey, one question: with respect to the release note, what is the user facing change? Is kubeadm using the new etcd version?

Everything in the repo is included in the release, regardless.

EDIT: and kube-up.sh is "user facing" even if we pretend it's only for test, someone is using this in prod, and it was previously advertised for this usage. You can still get-kube.sh

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2020
@justaugustus
Copy link
Copy Markdown
Member

justaugustus commented Jun 20, 2020

/hold cancel
(Promotion successful in https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/post-k8sio-cip/1274443174978260992.)

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2020
@BenTheElder
Copy link
Copy Markdown
Member

BenTheElder commented Jun 20, 2020

kubeadm is still trying to pull from k8s.gcr.io (k8s.gcr.io/etcd:3.4.9-0)

on monday k8s.gcr.io is supposed to be live from k8s infra though ...

@justaugustus
Copy link
Copy Markdown
Member

justaugustus commented Jun 20, 2020

kubeadm is still trying to pull from k8s.gcr.io (k8s.gcr.io/etcd:3.4.9-0)

on monday k8s.gcr.io is supposed to be live from k8s infra though ...

@BenTheElder -- Heh. I was just about to ping you.
I'd say we wait on this PR until the vanity domain flip starts.

neolit123
neolit123 reviewed Jun 22, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jul 8, 2020

Pushed the images to the old prod registry as well.

@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jul 8, 2020

/retest

1 similar comment
@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jul 8, 2020

/retest

@neolit123
Copy link
Copy Markdown
Member

neolit123 commented Jul 9, 2020 •
edited
Loading

today is code freeze for 1.19. are we not merging this change?

BenTheElder
BenTheElder reviewed Jul 9, 2020
View reviewed changes
Comment thread cluster/gce/manifests/etcd.manifest
@BenTheElder
Copy link
Copy Markdown
Member

BenTheElder commented Jul 9, 2020

@neolit123 there's a minor bug in the PR

@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jul 13, 2020

today is code freeze for 1.19. are we not merging this change?

I think this PR is clean up. (#92075 is considered feature)

@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jul 13, 2020

/retest

1 similar comment
@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jul 14, 2020

/retest

@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jul 14, 2020

All tests passed. Could we get this in? @neolit123 @BenTheElder @justaugustus

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Jul 16, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, jingyih, justaugustus, liggitt, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2020
@justaugustus
Copy link
Copy Markdown
Member

justaugustus commented Jul 16, 2020

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@justaugustus
Copy link
Copy Markdown
Member

justaugustus commented Jul 16, 2020

/test pull-kubernetes-e2e-gce-100-performance

@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jul 16, 2020

/retest

@oomichi oomichi mentioned this pull request Jul 16, 2020
Merged
@lavalamp lavalamp mentioned this pull request Jul 16, 2020
Merged
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Jul 17, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@warmchang
Copy link
Copy Markdown
Contributor

warmchang commented Jul 17, 2020

/test pull-kubernetes-node-e2e
/test pull-kubernetes-kubemark-e2e-gce-big

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Jul 17, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jul 17, 2020

/retest

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 17, 2020 •
edited
Loading

@jingyih: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kind-ipv6 41dd0182c3758ca6bbfc3205218eeb2b7945db3c link /test pull-kubernetes-e2e-kind-ipv6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jul 17, 2020

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-kind

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Jul 17, 2020

/skip

@k8s-ci-robot k8s-ci-robot merged commit f9ad7db into kubernetes:master Jul 17, 2020
@hasheddan hasheddan mentioned this pull request Jul 19, 2020
Closed
@neolit123 neolit123 mentioned this pull request Jul 19, 2020
Closed
@github-actions github-actions Bot mentioned this pull request Jul 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@liggitt liggitt liggitt left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@justaugustus justaugustus justaugustus requested changes

@sttts sttts Awaiting requested review from sttts

@zmerlynn zmerlynn Awaiting requested review from zmerlynn

+1 more reviewer

@neolit123 neolit123 neolit123 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@justaugustus justaugustus

@BenTheElder BenTheElder

@liggitt liggitt

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/etcd area/kubeadm area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.19

Development

Successfully merging this pull request may close these issues.

Update to etcd 3.4.9 in Kubernetes 1.19