Skip to content

Update etcd makefile to build 3.4.9 image#92078

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
jingyih:update_etcd_makefile_for_3p4p9
Jun 17, 2020
Merged

Update etcd makefile to build 3.4.9 image#92078
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
jingyih:update_etcd_makefile_for_3p4p9

Conversation

@jingyih
Copy link
Copy Markdown
Contributor

@jingyih jingyih commented Jun 12, 2020 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
We are updating etcd client version to 3.4.9 in #92075. This PR updates the etcd makefile to match the version, so that 3.4.9 images can be built.

Which issue(s) this PR fixes:
#91266

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/sig api-machinery
/area etcd

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. area/etcd cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 12, 2020
@k8s-ci-robot k8s-ci-robot requested review from jpbetz and wenjiaswe June 12, 2020 16:11
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 12, 2020
@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jun 12, 2020

cc @dims @jpbetz @wenjiaswe

@jingyih jingyih force-pushed the update_etcd_makefile_for_3p4p9 branch from f61c8a4 to 303273d Compare June 12, 2020 16:21
@jingyih jingyih mentioned this pull request Jun 12, 2020
Closed
4 tasks
@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jun 12, 2020

@dims pull-kubernetes-dependencies is complaining about etcd version mismatch in the codebase. This means we cannot modify the etcd makefile to trigger the automatic image building process as the first step?

@BenTheElder
Copy link
Copy Markdown
Member

BenTheElder commented Jun 12, 2020

if the build is now automated and done in postsubmit this entry should be forked into the image and it's consumers

kubernetes/build/dependencies.yaml

Line 46 in 2402bfd

- name: "etcd"

@tedyu tedyu mentioned this pull request Jun 13, 2020
Closed
@jingyih jingyih force-pushed the update_etcd_makefile_for_3p4p9 branch 2 times, most recently from 25734eb to 3ba87cd Compare June 14, 2020 19:36
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 14, 2020
@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jun 15, 2020

/retest

@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jun 15, 2020

if the build is now automated and done in postsubmit this entry should be forked into the image and it's consumers

kubernetes/build/dependencies.yaml

Line 46 in 2402bfd

- name: "etcd"

@BenTheElder Could you help take a look if this is right?
3ba87cd

@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jun 15, 2020 •
edited
Loading

/assign @dims @jpbetz
PTAL

BenTheElder
BenTheElder reviewed Jun 15, 2020
View reviewed changes
Comment thread build/dependencies.yaml Outdated
Copy link
Copy Markdown
Member

@BenTheElder BenTheElder Jun 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe give these entries different names?

Suggested change
- name: "etcd"
- name: "etcd-image"

Copy link
Copy Markdown
Contributor Author

@jingyih jingyih Jun 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks!

@BenTheElder
Copy link
Copy Markdown
Member

BenTheElder commented Jun 15, 2020

one suggestion, otherwise LGTM, thank you!

@BenTheElder
Copy link
Copy Markdown
Member

BenTheElder commented Jun 15, 2020

/assign

@justaugustus
Copy link
Copy Markdown
Member

justaugustus commented Jun 15, 2020

FYI @kubernetes/release-engineering

@jingyih
Split etcd version match into two entries
2444f5e 
To have a separate entry for etcd image.
@jingyih jingyih force-pushed the update_etcd_makefile_for_3p4p9 branch from 3ba87cd to 2444f5e Compare June 15, 2020 20:20
@BenTheElder
Copy link
Copy Markdown
Member

BenTheElder commented Jun 15, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 15, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, jingyih

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2020
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Jun 16, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

4 similar comments
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Jun 16, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Jun 16, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Jun 16, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Jun 16, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@BenTheElder
Copy link
Copy Markdown
Member

BenTheElder commented Jun 16, 2020

finally green 🤞

@k8s-ci-robot k8s-ci-robot merged commit 78774eb into kubernetes:master Jun 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 17, 2020
@BenTheElder
Copy link
Copy Markdown
Member

BenTheElder commented Jun 20, 2020

@jingyih did we bump the consumers?

@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jun 20, 2020

@jingyih did we bump the consumers?

Sorry for the delay. Just created kubernetes/k8s.io#973 to promote the images to prod repo. Once it is done, we can bump the consumers.

@jingyih jingyih mentioned this pull request Jun 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@jpbetz jpbetz Awaiting requested review from jpbetz

@wenjiaswe wenjiaswe Awaiting requested review from wenjiaswe

Assignees

@dims dims

@jpbetz jpbetz

@BenTheElder BenTheElder

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/etcd area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.19

Development

Successfully merging this pull request may close these issues.

7 participants

@jingyih @BenTheElder @justaugustus @k8s-ci-robot @fejta-bot @dims @jpbetz