Skip to content

Update etcd client to v3.4.9#92075

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
jingyih:update_etcd_client_3p4p9
Jun 13, 2020
Merged

Update etcd client to v3.4.9#92075
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
jingyih:update_etcd_client_3p4p9

Conversation

@jingyih
Copy link
Copy Markdown
Contributor

@jingyih jingyih commented Jun 12, 2020

What type of PR is this?
/kind feature

Which issue(s) this PR fixes:
#91266

Does this PR introduce a user-facing change?:

Update etcd client side to v3.4.9

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 12, 2020
@k8s-ci-robot k8s-ci-robot requested review from a team, roycaihw and smarterclayton June 12, 2020 15:50
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Jun 12, 2020
@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jun 12, 2020

cc @dims @justaugustus @kubernetes/release-engineering @BenTheElder

@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jun 12, 2020

@liggitt Could you please help double check go mod related changes

@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jun 12, 2020

cc @wojtek-t @jpbetz @wenjiaswe

This was referenced Jun 12, 2020
Closed
Merged
@jingyih
Copy link
Copy Markdown
Contributor Author

jingyih commented Jun 12, 2020

/retest

@BenTheElder
Copy link
Copy Markdown
Member

BenTheElder commented Jun 12, 2020

/approve
(for vendor/)

@dims
Copy link
Copy Markdown
Member

dims commented Jun 13, 2020

/assign @liggitt

@dims
Copy link
Copy Markdown
Member

dims commented Jun 13, 2020

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 13, 2020
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Jun 13, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, jingyih, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0703d68 into kubernetes:master Jun 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 13, 2020
@wojtek-t
Copy link
Copy Markdown
Member

wojtek-t commented Jun 14, 2020

lgtm thanks!

@github-actions github-actions Bot mentioned this pull request Jun 16, 2020
Open
@liggitt liggitt mentioned this pull request Jun 17, 2020
Closed
@jingyih jingyih mentioned this pull request Jun 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roycaihw roycaihw Awaiting requested review from roycaihw

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@liggitt liggitt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.19

Development

Successfully merging this pull request may close these issues.

6 participants

@jingyih @BenTheElder @dims @liggitt @k8s-ci-robot @wojtek-t