Skip to content

bump cni library version to v0.8.0 #91896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jul 2, 2020
Merged

bump cni library version to v0.8.0 #91896

k8s-ci-robot merged 1 commit into from
Jul 2, 2020

Conversation

@aojea
Copy link
Member

@aojea aojea commented Jun 8, 2020 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup

/kind deprecation
/kind design
/kind documentation
/kind failing-test

/kind feature
/kind flake

What this PR does / why we need it:

last CNI library release is 0.7.1 from Jun 11, 2019.
Since then, there was introduced new feature and bugfixes.

Currently, this library is only being used by dockershim,
the other CRI plugins are vendoring it directly

However, this will help also to mitigate some of the issues with the
CI jobs that are still using dockershim.

Specially interesting the new cache feature and some bugfixes to improve
resilience to errors.

Signed-off-by: Antonio Ojea [email protected]

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 8, 2020
@aojea
Copy link
Member Author

aojea commented Jun 8, 2020

/assign @BenTheElder @liggitt @dims

@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jun 8, 2020
@k8s-ci-robot k8s-ci-robot requested review from a team, dchen1107 and smarterclayton June 8, 2020 09:32
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/kubelet sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 8, 2020
@dims
Copy link
Member

dims commented Jun 8, 2020

@aojea let's please ask them to tag 0.7.2 for us to use.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2020
This was referenced Jun 8, 2020
Merged
Merged
@aojea
Copy link
Member Author

aojea commented Jun 8, 2020

poke to cni maintainer to see if they can tag a new release
/cc @squeed

@k8s-ci-robot k8s-ci-robot requested a review from squeed June 8, 2020 15:14
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2020
@bboreham
Copy link
Contributor

bboreham commented Jun 18, 2020

let's please ask them to tag 0.7.2 for us to use.

Opening an issue in the CNI repo would be a good way to do that.

I believe it would be 0.8.0 due to a (minor) interface change.

@aojea aojea mentioned this pull request Jun 18, 2020
Closed
@aojea
bump cni library version to v0.8.0
6f79600 
last CNI library release is 0.7.1 from Jun 11, 2019.
Since then, there was introduced new feature and bugfixes.

Currently, this library is only being used by dockershim,
the other CRI plugins are vendoring it directly

However, this will help also to mitigate some of the issues with the
CI jobs that are still using dockershim.

Signed-off-by: Antonio Ojea <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2020
@aojea
Copy link
Member Author

aojea commented Jul 1, 2020

@dims updated to latest cni release
thanks @bboreham

@aojea aojea changed the title bump cni library version bump cni library version to v0.8.0 Jul 1, 2020
@dims
Copy link
Member

dims commented Jul 1, 2020

/retest

@liggitt this looks ready!

liggitt
liggitt reviewed Jul 1, 2020
View reviewed changes
vendor/github.com/containernetworking/cni/pkg/invoke/raw_exec.go
Comment on lines +52 to +57
// If the plugin is currently about to be written, then we wait a
// second and try it again
if strings.Contains(err.Error(), "text file busy") {
time.Sleep(time.Second)
continue
}
Copy link
Member

@liggitt liggitt Jul 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a path in kube that hits this?

Copy link
Member Author

@aojea aojea Jul 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saschagrunert you've added this containernetworking/cni#763,
can you help me to answer this question 😄 ?

Copy link
Member

@saschagrunert saschagrunert Jul 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a setup race where the init container downloads the CNI Plugin binary (like Cilium) and the runtime immediately picks up the (not finished copying) executable on disk. This caused issues in multiple distributions on cluster bootstrap, so we added this feature of retrying.

I don’t think that CNI invocations happen directly via Kubernetes, usually the runtime does this (last famous words).

@liggitt
Copy link
Member

liggitt commented Jul 1, 2020

/approve
/retest
/hold one question about the retry...

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 1, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2020
saschagrunert
saschagrunert approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2020
@liggitt
Copy link
Member

liggitt commented Jul 1, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit ce5c89a into kubernetes:master Jul 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liggitt liggitt liggitt left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@squeed squeed Awaiting requested review from squeed

Assignees

@dims dims

@saschagrunert saschagrunert

@BenTheElder BenTheElder

@liggitt liggitt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.19

Development

Successfully merging this pull request may close these issues.

7 participants

@aojea @dims @bboreham @liggitt @k8s-ci-robot @saschagrunert @BenTheElder