Skip to content

Update Golang to v1.14.4#88638

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
justaugustus:go1140
Jun 23, 2020
Merged

Update Golang to v1.14.4#88638
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
justaugustus:go1140

Conversation

@justaugustus
Copy link
Copy Markdown
Member

@justaugustus justaugustus commented Feb 28, 2020 •
edited
Loading

What type of PR is this?
/kind cleanup
/area dependency release-eng
/sig release

What this PR does / why we need it:
Update Golang to v1.14.4

Signed-off-by: Stephen Augustus [email protected]

/assign @liggitt @cblecker @dims @BenTheElder @listx
cc: @kubernetes/release-engineering
ref: kubernetes/release#1216

Does this PR introduce a user-facing change?:

Update Golang to v1.14.4

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2020
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 28, 2020
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 28, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 28, 2020
@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Feb 28, 2020

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 28, 2020
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 28, 2020
@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Feb 28, 2020

pull-kubernetes-cross is an expected failure as the kube-cross image for go1.14.0 doesn't exist yet.
Once this PR passes other tests, I'll build and promote the new kube-cross image.

@justaugustus justaugustus mentioned this pull request Feb 28, 2020
Closed
25 tasks
@mm4tt
Copy link
Copy Markdown
Contributor

mm4tt commented Feb 28, 2020

FTR, SIG Scalability worked with golang folks on 1.14 release qualification - golang/go#36752
We had some performance regressions but they have been fixed and golang1.14 is good to go from the scalability/performance perspective.

@justaugustus, for the future, could you add someone from sig-scalability when you update golang to new minor version to double check? This time we managed to beat the regression before first minor release, but for 1.13 a few first patch releases were not good from scale perspective (see golang/go#32828, IIRC 1.13.3 was the first good release).

Thanks!

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Feb 28, 2020

looks like etcd tests are unhappy with go1.14:

$ go test -race k8s.io/apiserver/pkg/storage/etcd3 |& pp
fatal error: checkptr: unsafe pointer conversion
FAIL	k8s.io/apiserver/pkg/storage/etcd3	0.238s
FAIL
1: running [Created by integration.(*cluster).Launch @ cluster.go:223]
    runtime     panic.go:1112         throw(string(0x2375c38, len=35))
    runtime     checkptr.go:18        checkptrAlignment(Pointer(0xc0002c2130), *_type(0x1))
    bbolt       bucket.go:624         (*Bucket).write(*Bucket(0xc0002bf220), 0x0, 0x0, 0x0)
    bbolt       bucket.go:181         (*Bucket).CreateBucket(*Bucket(0xc000202478), []byte(#1 len=7 cap=7), 0xc0002bf480, 0x1e17936, 0xc000298978)
    bbolt       tx.go:108             (*Tx).CreateBucket(...)
    backend     batch_tx.go:72        (*batchTx).UnsafeCreateBucket(*batchTx(#4), []byte(#1 len=7 cap=7))
    backend     <autogenerated>:1     (*batchTxBuffered).UnsafeCreateBucket(#4, #1, 0x7, 0x7)
    membership  store.go:166          mustCreateBackendBuckets(Backend(0x25e26c0))
    membership  cluster.go:242        (*RaftCluster).SetBackend(...)
    etcdserver  server.go:406         NewServer(ServerConfig(0xc0001d9ca0), 0x0, 0x0, 0x0, 0x0, 0xc00020eb00, 0x1, 0x1, 0xc00020e880, ...)
    integration cluster.go:801        (*member).Launch(*member(#3), 0x0, 0x0)
    integration cluster.go:224        (*cluster).Launch.func1(*cluster(0xc000190900), TB(#3))
    runtime     asm_amd64.s:1373      goexit()

xref etcd-io/bbolt#187

cc @enj @jpbetz

@enj
Copy link
Copy Markdown
Member

enj commented Feb 28, 2020

looks like etcd tests are unhappy with go1.14

If we want to be terrible people, we can do -gcflags=all=-d=checkptr=0 per the release notes to turn off the new check. I do not know how that flags interacts with -race.

@prestonvanloon prestonvanloon mentioned this pull request Feb 28, 2020
Merged
@jpbetz
Copy link
Copy Markdown
Contributor

jpbetz commented Feb 29, 2020 via email

@listx
Copy link
Copy Markdown

listx commented Mar 7, 2020

I suppose this PR is blocked on forthcoming(?) etcd fixes...?

@RainbowMango
Copy link
Copy Markdown
Member

RainbowMango commented Mar 7, 2020

We'd better take a look at the mlock issue before update to v1.14.

@justaugustus justaugustus changed the title [WIP] Update Golang to v1.14.4 Update Golang to v1.14.4 Jun 22, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2020
@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Jun 22, 2020

/assign @liggitt @BenTheElder @cblecker

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Jun 22, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2020
@cblecker
Copy link
Copy Markdown
Member

cblecker commented Jun 22, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, fejta, justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Jun 22, 2020

/test pull-kubernetes-e2e-kind-ipv6

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 23, 2020

@justaugustus: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kind-ipv6 b0f17c2 link /test pull-kubernetes-e2e-kind-ipv6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Jun 23, 2020

/test pull-kubernetes-e2e-kind-ipv6

@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Jun 23, 2020

F I N A L L Y .
/honk
/pony party

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 23, 2020

@justaugustus:
goose image

Details

In response to this:

F I N A L L Y .
/honk
/pony party

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 23, 2020

@justaugustus: pony image

Details

In response to this:

F I N A L L Y .
/honk
/pony party

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jun 23, 2020
Merged
Merged
@RainbowMango
Copy link
Copy Markdown
Member

RainbowMango commented Jun 23, 2020

Congrats! It's quite a long ride!

@seanmalloy seanmalloy mentioned this pull request Jun 23, 2020
Merged
@BenTheElder
Copy link
Copy Markdown
Member

BenTheElder commented Jun 23, 2020 via email

@damemi damemi mentioned this pull request Jun 23, 2020
Merged
@liggitt liggitt mentioned this pull request Jun 23, 2020
Merged
@github-actions github-actions Bot mentioned this pull request Jun 23, 2020
Open
This was referenced Jun 24, 2020
Merged
Merged
Merged
@liggitt liggitt mentioned this pull request Jun 25, 2020
Closed
@github-actions github-actions Bot mentioned this pull request Jun 30, 2020
Open
@fisherxu fisherxu mentioned this pull request Jul 1, 2020
Merged
@haircommander haircommander mentioned this pull request Jul 2, 2020
Closed
@rifelpet rifelpet mentioned this pull request Jul 5, 2020
Merged
@mogren mogren mentioned this pull request Aug 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

1 more reviewer

@fejta fejta fejta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@listx listx

@BenTheElder BenTheElder

@fejta fejta

@liggitt liggitt

@cblecker cblecker

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.19

Development

Successfully merging this pull request may close these issues.