Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the RuntimeClass admission controller on GCE & CI #82094

Merged
merged 2 commits into from
Aug 30, 2019
Merged

Enable the RuntimeClass admission controller on GCE & CI #82094

merged 2 commits into from
Aug 30, 2019

Conversation

tallclair
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:

Follow up to #81862, I didn't realize we were overriding the admission controllers in the default GCE / CI environment.

Which issue(s) this PR fixes:
Unblocks #81915

Does this PR introduce a user-facing change?:

NONE

/sig node
/priority important-soon
/milestone v1.16

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Aug 28, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 28, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 28, 2019
@tallclair tallclair mentioned this pull request Aug 28, 2019
Merged
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Aug 28, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 29, 2019
@tallclair tallclair force-pushed the runtime-class-admission branch from 8f5aaeb to 5023132 Compare August 29, 2019 16:32
@tallclair tallclair force-pushed the runtime-class-admission branch from 5023132 to 2c01dc0 Compare August 29, 2019 17:57
@tallclair
Copy link
Member Author

Fixed test to use the created pod, otherwise it doesn't get the generated name.

draveness
draveness reviewed Aug 29, 2019
View reviewed changes
Copy link
Contributor

@draveness draveness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2019
yastij
yastij reviewed Aug 29, 2019
View reviewed changes
Copy link
Member

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mikedanese
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikedanese, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2019
@draveness draveness mentioned this pull request Aug 30, 2019
Closed
7 tasks
@k8s-ci-robot k8s-ci-robot merged commit 7a7b8a7 into kubernetes:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draveness draveness draveness left review comments

@yastij yastij yastij left review comments

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@mikedanese mikedanese

@draveness draveness

@yastij yastij

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
5 participants
@tallclair @mikedanese @k8s-ci-robot @draveness @yastij