Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the RuntimeClass admission controller for scheduling #81862

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Enable the RuntimeClass admission controller for scheduling #81862

merged 1 commit into from
Aug 27, 2019

Conversation

tallclair
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
With #81072, the RuntimeClass admission controller is no longer only tied to PodOverhead, so enable it whenever the RuntimeClass feature is enabled.

Which issue(s) this PR fixes:
For #81016

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/runtime-class-scheduling.md

/priority important-soon
/milestone v1.16
/sig node
/cc @egernst @draveness
/assign @thockin

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 23, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 23, 2019
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Aug 23, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Aug 23, 2019
mattjmcnaughton
mattjmcnaughton reviewed Aug 24, 2019
View reviewed changes
Copy link
Contributor

@mattjmcnaughton mattjmcnaughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, was it possible to turn on the RuntimeClass feature before this diff? Was doing so just a no-op?

Code here looks good to me :) Will let someone else sign off on actually turning the feature via the new flag.

draveness
draveness approved these changes Aug 24, 2019
View reviewed changes
pkg/kubeapiserver/options/plugins.go
@@ -148,7 +148,7 @@ func DefaultOffAdmissionPlugins() sets.String {
defaultOnPlugins.Insert(nodetaint.PluginName) //TaintNodesByCondition
}

if utilfeature.DefaultFeatureGate.Enabled(features.PodOverhead) {
if utilfeature.DefaultFeatureGate.Enabled(features.RuntimeClass) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2019
This was referenced Aug 25, 2019
Closed
Merged
@tallclair
Copy link
Member Author

/retest

@mattjmcnaughton before v1.16 this admission controller didn't exist. The RuntimeClass feature is mostly used by the Kubelet, and by the apiserver to handle the API.

@roycaihw
Copy link
Member

/cc @liggitt

@k8s-ci-robot k8s-ci-robot requested a review from liggitt August 26, 2019 21:06
@josiahbjorgaard
Copy link
Contributor

This is a gentle reminder of code freeze for v1.16 coming this Thursday by EOD (PST). It looks like this PR is under review. Please comment if it is not expected to merged before code freeze so that it can be moved out of the milestone.

@thockin
Copy link
Member

thockin commented Aug 27, 2019

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tallclair, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit 419dccb into kubernetes:master Aug 27, 2019
@tallclair tallclair mentioned this pull request Aug 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjmcnaughton mattjmcnaughton mattjmcnaughton left review comments

@draveness draveness draveness approved these changes

@egernst egernst Awaiting requested review from egernst

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@thockin thockin

@draveness draveness

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
7 participants
@tallclair @roycaihw @josiahbjorgaard @thockin @k8s-ci-robot @mattjmcnaughton @draveness