Skip to content

[1.16] Stop serving deprecated beta workload APIs#70672

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
liggitt:stop-serving-beta-apps
Jun 22, 2019
Merged

[1.16] Stop serving deprecated beta workload APIs#70672
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
liggitt:stop-serving-beta-apps

Conversation

@liggitt
Copy link
Copy Markdown
Member

@liggitt liggitt commented Nov 5, 2018 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

  • Disables default serving of apps/v1beta1, apps/v1beta2, and deprecated extensions/v1beta1 APIs

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

xref #43214

Does this PR introduce a user-facing change?:

The following APIs are no longer served by default:
* All resources under `apps/v1beta1` and `apps/v1beta2` - use `apps/v1` instead
* `daemonsets`, `deployments`, `replicasets` resources under `extensions/v1beta1` - use `apps/v1` instead
* `networkpolicies` resources under `extensions/v1beta1` - use `networking.k8s.io/v1` instead
* `podsecuritypolicies` resources under `extensions/v1beta1` - use `policy/v1beta1` instead

Serving these resources can be temporarily re-enabled using the `--runtime-config` apiserver flag. 
* `apps/v1beta1=true`
* `apps/v1beta2=true`
* `extensions/v1beta1/daemonsets=true,extensions/v1beta1/deployments=true,extensions/v1beta1/replicasets=true,extensions/v1beta1/networkpolicies=true,extensions/v1beta1/podsecuritypolicies=true`

The ability to serve these resources will be completely removed in v1.18.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/kubectl kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 5, 2018
@k8s-ci-robot k8s-ci-robot requested a review from adohe-zz November 5, 2018 22:57
@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Nov 5, 2018
@k8s-ci-robot k8s-ci-robot requested a review from apelisse November 5, 2018 22:57
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/gcp sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 5, 2018
@liggitt liggitt added sig/network Categorizes an issue or PR as relevant to SIG Network. sig/auth Categorizes an issue or PR as relevant to SIG Auth. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. and removed area/apiserver area/kubectl kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. labels Nov 5, 2018
@neolit123
Copy link
Copy Markdown
Member

neolit123 commented Jun 23, 2019

would it make sense to have this as an item under "action required"?

existing manifests (e.g. CNI deployments) trying to be applied against latest k/k master will fail if they are using: extensions/v1beta1. this hints that CNI providers may have to adapt.

@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Jun 23, 2019

Definitely, tagged

@BenTheElder
Copy link
Copy Markdown
Member

BenTheElder commented Jun 23, 2019

"CNI providers may..." = We goofed that in kind. Whoops 🙃 .. fixed now. Hopefully everyone else long since migrated when the APIs went stable 😉

This was referenced Jun 24, 2019
Merged
Merged
@benmoss benmoss mentioned this pull request Jun 24, 2019
Closed
This was referenced Jun 24, 2019
Closed
Closed
@lilic lilic mentioned this pull request Jun 25, 2019
Closed
@mboersma mboersma mentioned this pull request Jun 25, 2019
Merged
4 tasks
@cofyc cofyc mentioned this pull request Jun 26, 2019
Merged
@qw1mb0 qw1mb0 mentioned this pull request Jun 27, 2019
Merged
This was referenced Jun 30, 2019
Closed
Closed
@wongma7 wongma7 mentioned this pull request Jul 18, 2019
Merged
@leakingtapan leakingtapan mentioned this pull request Jul 19, 2019
Closed
@wongma7 wongma7 mentioned this pull request Jul 24, 2019
Merged
@MrHohn MrHohn mentioned this pull request Jul 29, 2019
Merged
@alpeb alpeb mentioned this pull request Aug 30, 2019
Closed
@micw523 micw523 mentioned this pull request Sep 24, 2019
Merged
@roycaihw roycaihw mentioned this pull request Sep 24, 2019
Closed
@micw523 micw523 mentioned this pull request Sep 24, 2019
Closed
3 tasks
@qadet123 qadet123 mentioned this pull request Oct 16, 2019
Closed
@YuikoTakada YuikoTakada mentioned this pull request Nov 12, 2019
Merged
@zhouya0 zhouya0 mentioned this pull request Nov 18, 2019
Merged
@bpietraga bpietraga mentioned this pull request Nov 27, 2019
Merged
@Danil-Grigorev Danil-Grigorev mentioned this pull request Feb 28, 2020
Closed
@pigletfly pigletfly mentioned this pull request Nov 3, 2020
Closed
@Sea-n Sea-n mentioned this pull request Apr 14, 2022
Merged
@carlory carlory mentioned this pull request Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adohe-zz adohe-zz Awaiting requested review from adohe-zz

@apelisse apelisse Awaiting requested review from apelisse

1 more reviewer

@janetkuo janetkuo janetkuo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bowei bowei

@smarterclayton smarterclayton

@janetkuo janetkuo

@thockin thockin

@kow3ns kow3ns

@tallclair tallclair

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

v1.16

Development

Successfully merging this pull request may close these issues.