Set api version and action name in fake evictions #69035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/kind bug |
k8s-ci-robot
added
kind/bug
Merged
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @caesarxuchao |
|
/lgtm |
k8s-ci-robot
removed
the
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caesarxuchao, dmathieu, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest Review the full test history for this PR. Silence the bot with an |
|
/sig testing |
k8s-ci-robot
added
sig/testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The mock for evicting a Pod doesn't set the API version, preventing us from finding the pod to evict later on.
We try finding every pods matching the
GroupVersionResourcehere. So not setting any API version gives us 404s all the time.This change also sets the pod name to evict as the action name, so we can properly fetch the right Pod.
Special notes for your reviewer:
The fake package has absolutely no tests. So I haven't written any here. It feels like setting up tests here would be quite useful.
Provided with a bit of guidance, I wouldn't mind working on that.
Release note: