improve kubeconfig file modification time #67093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
|
@juanvallejo /sig api-machinery |
k8s-ci-robot
added
sig/api-machinery
|
It looks like this works. Please confirm there is test coverage on this. |
Trades runtime complexity for spacial complexity when modifying large amounts of contexts on a kubeconfig. In cases where there are few destination filenames for a given amount of contexts, but a large amount of contexts, this patch prevents reading and writing to the same file (or small number of files) over and over again needlessly.
juanvallejo
force-pushed
the
jvallejo/improve-config-context-update
branch
from
2c05e89 to
d565194
Compare
k8s-ci-robot
added
size/M
Added a test for context modification |
|
/lgtm |
k8s-ci-robot
added
lgtm
|
/assign @yliaog |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, juanvallejo, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 67161, 67093, 67077). If you want to cherry-pick this change to another branch, please follow the instructions here. |
k8s-github-robot
pushed a commit
that referenced
this pull request
Aug 15, 2018
…fig-tests Automatic merge from submit-queue (batch tested with PRs 67347, 67307, 67358, 67364, 67385). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. use temp file for kubeconfig in test Followup to #67093 Updates client_config_test to use a temporary file for kubeconfig. **Release note**: ```release-note NONE ``` cc @deads2k @soltysh
k8s-publishing-bot
added a commit
to kubernetes/client-go
that referenced
this pull request
Aug 16, 2018
…fig-tests Automatic merge from submit-queue (batch tested with PRs 67347, 67307, 67358, 67364, 67385). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. use temp file for kubeconfig in test Followup to kubernetes/kubernetes#67093 Updates client_config_test to use a temporary file for kubeconfig. **Release note**: ```release-note NONE ``` cc @deads2k @soltysh Kubernetes-commit: 46bfa1ab17afaffc584f560ee5c752ecbbad4f61
sttts
pushed a commit
to sttts/client-go
that referenced
this pull request
Sep 5, 2018
…fig-tests Automatic merge from submit-queue (batch tested with PRs 67347, 67307, 67358, 67364, 67385). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. use temp file for kubeconfig in test Followup to kubernetes/kubernetes#67093 Updates client_config_test to use a temporary file for kubeconfig. **Release note**: ```release-note NONE ``` cc @deads2k @soltysh Kubernetes-commit: 46bfa1ab17afaffc584f560ee5c752ecbbad4f61
k8s-publishing-bot
added a commit
to kubernetes/client-go
that referenced
this pull request
Sep 6, 2018
…fig-tests Automatic merge from submit-queue (batch tested with PRs 67347, 67307, 67358, 67364, 67385). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. use temp file for kubeconfig in test Followup to kubernetes/kubernetes#67093 Updates client_config_test to use a temporary file for kubeconfig. **Release note**: ```release-note NONE ``` cc @deads2k @soltysh Kubernetes-commit: 46bfa1ab17afaffc584f560ee5c752ecbbad4f61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where there are few destination filenames for a given
amount of contexts, but a large amount of contexts, this patch
prevents reading and writing to the same file (or small number
of files) over and over again needlessly.
Release note:
cc @deads2k