Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the in-tree keystone plugin #64346

Merged
merged 1 commit into from
Jun 2, 2018
Merged

Deprecate the in-tree keystone plugin #64346

merged 1 commit into from
Jun 2, 2018

Conversation

dims
Copy link
Member

@dims dims commented May 25, 2018

What this PR does / why we need it:

We now have the client-keystone-auth in cloud-provider-openstack
repository:
https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/using-client-keystone-auth.md

So let's drop the in-tree one, so we can remove it in 1.12

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

in-tree support for openstack credentials is now deprecated. please use the "client-keystone-auth" from the cloud-provider-openstack repository. details on how to use this new capability is documented here - https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/using-client-keystone-auth.md

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 25, 2018
@k8s-ci-robot k8s-ci-robot requested review from lavalamp and pmorie May 25, 2018 23:00
@dims
Copy link
Member Author

dims commented May 25, 2018

/cc @hogepodge
/cc @dklyle

@k8s-ci-robot k8s-ci-robot requested review from dklyle and hogepodge May 25, 2018 23:00
@dims
Copy link
Member Author

dims commented May 27, 2018

/retest

1 similar comment
@dims
Copy link
Member Author

dims commented May 27, 2018

/retest

@dims
Copy link
Member Author

dims commented May 29, 2018

/test pull-kubernetes-integration

@dims dims force-pushed the deprecate-in-tree-keystone-plugin branch from 20df993 to 14a06cc Compare May 29, 2018 14:39
@dims
Copy link
Member Author

dims commented May 29, 2018

/test pull-kubernetes-e2e-kops-aws

@dims
Deprecate the in-tree keystone plugin
ffe817f 
We now have the `client-keystone-auth` in cloud-provider-openstack
repository:
https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/using-client-keystone-auth.md

So let's drop the in-tree one, so we can remove it in 1.12
@dims dims force-pushed the deprecate-in-tree-keystone-plugin branch from 14a06cc to ffe817f Compare May 29, 2018 20:05
@dims
Copy link
Member Author

dims commented May 29, 2018

/retest

@hogepodge
Copy link

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2018
@dims
Copy link
Member Author

dims commented May 30, 2018

/milestone v1.11
/sig openstack

@k8s-ci-robot k8s-ci-robot added the area/provider/openstack Issues or PRs related to openstack provider label May 30, 2018
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone May 30, 2018
@dims
Copy link
Member Author

dims commented May 30, 2018

/assign @smarterclayton

@dims
Copy link
Member Author

dims commented May 30, 2018

/assign @liggitt

@dims
Copy link
Member Author

dims commented May 31, 2018

/kind cleanup
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 31, 2018
@liggitt
Copy link
Member

liggitt commented May 31, 2018

So let's drop the in-tree one, so we can remove it in 1.12

announcing deprecation now is fine, though removing it in 1.12 seems more aggressive than the deprecation policy allows (unless I'm missing where the openstack support is marked experimental or alpha)

@dims
Copy link
Member Author

dims commented Jun 1, 2018

/status approved-for-milestone

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@dims @hogepodge @liggitt @smarterclayton

Pull Request Labels
  • sig/openstack: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/cleanup: Adding tests, refactoring, fixing old bugs.
Help

@dims
Copy link
Member Author

dims commented Jun 1, 2018

@liggitt ack, we can decide later if 1.12 is not appropriate per rules.

@liggitt
Copy link
Member

liggitt commented Jun 2, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, hogepodge, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 64057, 63223, 64346, 64562, 64408). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 10d0c5c into kubernetes:master Jun 2, 2018
@enj enj mentioned this pull request Mar 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@pmorie pmorie Awaiting requested review from pmorie

@dklyle dklyle Awaiting requested review from dklyle

@hogepodge hogepodge Awaiting requested review from hogepodge

Assignees

@hogepodge hogepodge

@liggitt liggitt

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.
6 participants
@dims @hogepodge @liggitt @k8s-github-robot @k8s-ci-robot @smarterclayton