Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove service.deletecollection since the server doesn't support it #63861

Merged
merged 2 commits into from
May 16, 2018
Merged

remove service.deletecollection since the server doesn't support it #63861

merged 2 commits into from
May 16, 2018

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented May 15, 2018

Updates the generated service client to match the API available.

@kubernetes/sig-api-machinery-pr-reviews
@kubernetes/api-reviewers

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 15, 2018
@deads2k deads2k mentioned this pull request May 15, 2018
Closed
@liggitt
Copy link
Member

liggitt commented May 15, 2018

Does the namespace client have the same issue?

@deads2k
Copy link
Contributor Author

deads2k commented May 15, 2018

Does the namespace client have the same issue?

I don't know. This came in off a bug report. Does it?

@deads2k deads2k force-pushed the client-09-clean branch from 86488a9 to eb438b0 Compare May 15, 2018 15:31
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 15, 2018
@deads2k
Copy link
Contributor Author

deads2k commented May 15, 2018

Does the namespace client have the same issue?

If you know/knew phrasing it as a question is a little obnoxious. Updated.

@liggitt
Copy link
Member

liggitt commented May 15, 2018

If you know/knew phrasing it as a question is a little obnoxious. Updated.

sorry, I knew namespaces didn't support delete collection. I didn't know if the namespace client had already been updated to skip this method as well.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2018
@deads2k
Copy link
Contributor Author

deads2k commented May 15, 2018

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 63589, 63644, 63861, 63872, 63847). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 49e9322 into kubernetes:master May 16, 2018
@deads2k deads2k deleted the client-09-clean branch July 3, 2018 18:05
@skitt skitt mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deads2k @liggitt @k8s-ci-robot @k8s-github-robot