Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move config flags to pkg/kubectl/genericclioptions #63514

Merged
merged 1 commit into from
May 17, 2018
Merged

move config flags to pkg/kubectl/genericclioptions #63514

merged 1 commit into from
May 17, 2018

Conversation

juanvallejo
Copy link
Contributor

@juanvallejo juanvallejo commented May 7, 2018 •
edited
Loading

Release note:

NONE

Moves ConfigFlags to pkg/kubectl/genericclioptions
Depends on #63550

cc @soltysh @deads2k

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 7, 2018
@k8s-ci-robot k8s-ci-robot requested review from mengqiy and soltysh May 7, 2018 22:20
@juanvallejo juanvallejo force-pushed the jvallejo/move-config-flags-genericclioptions branch from 2320dc7 to 1147e9c Compare May 7, 2018 22:47
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 7, 2018
@juanvallejo juanvallejo force-pushed the jvallejo/move-config-flags-genericclioptions branch 6 times, most recently from 8ce3cab to e66a08b Compare May 10, 2018 20:05
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 10, 2018
@juanvallejo juanvallejo force-pushed the jvallejo/move-config-flags-genericclioptions branch 2 times, most recently from 81bb22b to 1485d58 Compare May 10, 2018 21:11
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2018
@juanvallejo juanvallejo force-pushed the jvallejo/move-config-flags-genericclioptions branch from 1485d58 to 56bfafd Compare May 15, 2018 18:18
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 15, 2018
@juanvallejo juanvallejo force-pushed the jvallejo/move-config-flags-genericclioptions branch 2 times, most recently from 8713f20 to 99660a5 Compare May 15, 2018 20:01
deads2k
deads2k reviewed May 16, 2018
View reviewed changes
pkg/kubectl/cmd/cmd.go
@@ -274,8 +274,15 @@ func NewKubectlCommand(in io.Reader, out, err io.Writer) *cobra.Command {
BashCompletionFunction: bashCompletionFunc,
}

kubeConfigFlags := cmdutil.NewConfigFlags()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did this have to change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was setting the "normalize" functions within the ConfigFlags#AddFlags method before. This was bringing in an additional dependency "k8s.io/apiserver/pkg/util/flag" to genericclioptions. Rather than do that, I moved the normalize functions here instead.

@deads2k
Copy link
Contributor

deads2k commented May 16, 2018

/approve
/lgtm

/hold

holding pending the answer to my question, but it looks good.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2018
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2018
@deads2k
Copy link
Contributor

deads2k commented May 16, 2018

/hold cancel

rebase

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2018
@juanvallejo juanvallejo force-pushed the jvallejo/move-config-flags-genericclioptions branch from 99660a5 to 2ff780d Compare May 16, 2018 15:27
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2018
@juanvallejo juanvallejo force-pushed the jvallejo/move-config-flags-genericclioptions branch from 2ff780d to 876629f Compare May 16, 2018 15:31
@juanvallejo
Copy link
Contributor Author

@deads2k rebased

@deads2k
Copy link
Contributor

deads2k commented May 16, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, juanvallejo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juanvallejo
Copy link
Contributor Author

/test pull-kubernetes-kubemark-e2e-gce

1 similar comment
@juanvallejo
Copy link
Contributor Author

/test pull-kubernetes-kubemark-e2e-gce

@juanvallejo
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit a20964a into kubernetes:master May 17, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 17, 2018 •
edited
Loading

@juanvallejo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-device-plugin-gpu 876629f link /test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@juanvallejo juanvallejo deleted the jvallejo/move-config-flags-genericclioptions branch May 17, 2018 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@mengqiy mengqiy Awaiting requested review from mengqiy

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juanvallejo @deads2k @k8s-ci-robot @k8s-github-robot