Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move client based restmappers to client-go #63507

Merged
merged 3 commits into from
May 8, 2018
Merged

move client based restmappers to client-go #63507

merged 3 commits into from
May 8, 2018

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented May 7, 2018

Moves the client-based restmappers to client-go where everyone who needs them can have access.

the shortcuts which were moved server-side in at least 1.9 have been removed from being hardcoded in kubectl

@kubernetes/sig-cli-maintainers @kubernetes/sig-api-machinery-pr-reviews

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 7, 2018
@deads2k
Copy link
Contributor Author

deads2k commented May 7, 2018

@soltysh @juanvallejo this is on the path to having a resource builder that only need a clientconfig function.

@timothysc timothysc removed their request for review May 7, 2018 20:32
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 8, 2018
soltysh
soltysh approved these changes May 8, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2018
@deads2k
Copy link
Contributor Author

deads2k commented May 8, 2018

/retest

1 similar comment
@deads2k
Copy link
Contributor Author

deads2k commented May 8, 2018

/retest

@caesarxuchao
Copy link
Member

Moving the restmapper from client-go/discover to client-go/restmapper makes sense.
Moving the shortcut_restmapper from kubectl to client-go makes sense.

/approve

@deads2k
Copy link
Contributor Author

deads2k commented May 8, 2018

/retest

@deads2k deads2k added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: caesarxuchao, deads2k, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 63291, 63490, 60445, 63507, 63524). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit c27335f into kubernetes:master May 8, 2018
@ncdc ncdc mentioned this pull request May 17, 2018
Open
@deads2k deads2k deleted the cli-50-tidyup branch July 3, 2018 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@enisoc enisoc Awaiting requested review from enisoc

@ghodss ghodss Awaiting requested review from ghodss

@kow3ns kow3ns Awaiting requested review from kow3ns

@luxas luxas Awaiting requested review from luxas

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deads2k @caesarxuchao @k8s-ci-robot @k8s-github-robot @soltysh