Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated ExternalID #61877

Merged
merged 4 commits into from
Apr 19, 2018
Merged

remove deprecated ExternalID #61877

merged 4 commits into from
Apr 19, 2018

Conversation

mikedanese
Copy link
Member

@mikedanese mikedanese commented Mar 29, 2018 •
edited by liggitt
Loading

This field has been deprecated since 1.1. After we remove it we can remove "self delete" from the node's permission set.

@kubernetes/api-reviewers
@kubernetes/sig-auth-pr-reviews

fixes #61966
part of kubernetes/community#911

Kubelets will no longer set `externalID` in their node spec.

@mikedanese mikedanese self-assigned this Mar 29, 2018
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 29, 2018
@k8s-github-robot k8s-github-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Mar 29, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 18, 2018 •
edited
Loading

@mikedanese: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-100-performance 55a2f06ecf401a32e9e1907dcf08f29cda810a30 link /test pull-kubernetes-e2e-gce-100-performance

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikedanese
Copy link
Member Author

/retest

@liggitt
Copy link
Member

liggitt commented Apr 18, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2018
@tallclair
Copy link
Member

/lgtm

@mikedanese
Copy link
Member Author

@dims for cinder approval

@dims
Copy link
Member

dims commented Apr 18, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, mikedanese, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 62481, 62643, 61877, 62515). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit efadf7b into kubernetes:master Apr 19, 2018
@mikedanese mikedanese deleted the depeid branch April 19, 2018 01:10
@liggitt liggitt mentioned this pull request Apr 20, 2018
Merged
@jingxu97 jingxu97 mentioned this pull request May 11, 2018
Closed
zachaller added a commit to zachaller/kops that referenced this pull request May 16, 2018
@zachaller
Kuberenets 1.11 has deprecated ExternalID this replaces it with Provi…
4cb92b7 
…derID

Per kubernetes/kubernetes#61877 ExternalID
is now removed from k8s.
@zachaller zachaller mentioned this pull request May 16, 2018
Merged
@jiayingz jiayingz mentioned this pull request Jun 1, 2018
Closed
@MrHohn MrHohn mentioned this pull request Jun 8, 2018
Closed
@DirectXMan12 DirectXMan12 mentioned this pull request Jun 14, 2018
Merged
7 tasks
@stewart-yu stewart-yu mentioned this pull request Jul 25, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Jul 28, 2018
Merge pull request #66593 from stewart-yu/stewart-kubelet-commentclean
8e2a444 
Automatic merge from submit-queue (batch tested with PRs 66593, 66727, 66558). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

remove the outdate comments in tryRegisterWithAPIServer

**What this PR does / why we need it**:
some judgement about ExternalID removed in #61877, so remove the outdate comments in tryRegisterWithAPIServer


**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
@lareeth lareeth mentioned this pull request Jul 30, 2018
Closed
bigkraig added a commit to kubernetes-sigs/aws-load-balancer-controller that referenced this pull request Aug 8, 2018
@bigkraig
It's my understanding from kubernetes/kubernetes#61877 that this is d…
1249955 
…eprecated in 1.11 and not 1.10
@ankon ankon mentioned this pull request Feb 11, 2019
Closed
@draveness draveness mentioned this pull request Oct 24, 2019
Closed
@swatisehgal swatisehgal mentioned this pull request Jun 24, 2021
Closed
@SataQiu SataQiu mentioned this pull request Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtaufen mtaufen mtaufen left review comments

@liggitt liggitt liggitt left review comments

Assignees

@dims dims

@liggitt liggitt

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove deprecated ExternalID
8 participants
@mikedanese @liggitt @k8s-ci-robot @tallclair @dims @k8s-github-robot @mtaufen @jingxu97