Skip to content

Automated cherry pick of #61357: add udev to hyperkube and bump versions#61861

Merged
k8s-github-robot merged 1 commit intokubernetes:release-1.10from
rphillips:automated-cherry-pick-of-#61357-upstream-release-1.10
Apr 4, 2018
Merged

Automated cherry pick of #61357: add udev to hyperkube and bump versions#61861
k8s-github-robot merged 1 commit intokubernetes:release-1.10from
rphillips:automated-cherry-pick-of-#61357-upstream-release-1.10

Conversation

@rphillips
Copy link
Copy Markdown
Member

@rphillips rphillips commented Mar 28, 2018

Cherry pick of #61357 on release-1.10.

#61357: add udev to hyperkube and bump versions

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 28, 2018

@rphillips: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

Details

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #61357.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 28, 2018

@rphillips: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

Details

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 28, 2018
@k8s-ci-robot k8s-ci-robot requested review from cblecker and ixdy March 28, 2018 21:11
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 28, 2018
@rphillips rphillips mentioned this pull request Mar 28, 2018
Merged
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 28, 2018
@rphillips rphillips mentioned this pull request Mar 28, 2018
Merged
@ixdy
Copy link
Copy Markdown
Contributor

ixdy commented Mar 28, 2018

/lgtm

This will add ipset and udev to the hyperkube image.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 28, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2018
@cblecker
Copy link
Copy Markdown
Member

cblecker commented Mar 29, 2018

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 29, 2018
@rphillips rphillips mentioned this pull request Apr 3, 2018
Closed
@rphillips
Copy link
Copy Markdown
Member Author

rphillips commented Apr 3, 2018

Can this PR be merged into the 1.10 release branch?

@MaciekPytel MaciekPytel added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Apr 3, 2018
@rphillips
Copy link
Copy Markdown
Member Author

rphillips commented Apr 3, 2018

/test pull-kubernetes-kubemark-e2e-gce

@rphillips
Copy link
Copy Markdown
Member Author

rphillips commented Apr 3, 2018

/test pull-kubernetes-e2e-gce

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Apr 4, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Apr 4, 2018

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit ac3342b into kubernetes:release-1.10 Apr 4, 2018
@rphillips rphillips mentioned this pull request Apr 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@ixdy ixdy Awaiting requested review from ixdy

Assignees

@ixdy ixdy

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rphillips @k8s-ci-robot @ixdy @cblecker @k8s-github-robot @MaciekPytel