Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ObjectMeta and *Options from core api #61809

Merged
merged 1 commit into from
Apr 9, 2018
Merged

remove ObjectMeta and *Options from core api #61809

merged 1 commit into from
Apr 9, 2018

Conversation

hzxuzhonghu
Copy link
Member

remove ObjectMeta and *Options from core api

Fixes #61807

Special notes for your reviewer:

Release note:

Remove `ObjectMeta ` `ListOptions` `DeleteOptions` from core api group.  Please use that in meta/v1

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 28, 2018
@k8s-github-robot k8s-github-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Mar 28, 2018
@hzxuzhonghu
Copy link
Member Author

/assign @smarterclayton @liggitt

@hzxuzhonghu
Copy link
Member Author

/assign @deads2k

deads2k
deads2k reviewed Mar 29, 2018
View reviewed changes
pkg/api/testing/defaulting_test.go
@@ -155,7 +155,7 @@ func TestDefaulting(t *testing.T) {
c.FuzzNoCustom(s)
s.MatchExpressions = nil // need to fuzz this specially
},
func(s *apiv1.ListOptions, c fuzz.Continue) {
func(s *metav1.ListOptions, c fuzz.Continue) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check for an existing fuzzer in apimachinery for this

@deads2k
Copy link
Contributor

deads2k commented Mar 29, 2018

comment on test, squash the generated changes into a single generation commit.

@smarterclayton for approval

@hzxuzhonghu
Copy link
Member Author

squashed

@hzxuzhonghu
Copy link
Member Author

ping @smarterclayton for approval

@smarterclayton
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2018
@hzxuzhonghu
Copy link
Member Author

@deads2k need a lgtm tag

@deads2k
Copy link
Contributor

deads2k commented Apr 9, 2018

/lgtm
/hold

holding for squash, feel free to remove after squashing.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 9, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2018
@hzxuzhonghu
Copy link
Member Author

Done

@hzxuzhonghu
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2018
@deads2k
Copy link
Contributor

deads2k commented Apr 9, 2018

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, hzxuzhonghu, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 60692, 61809). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 7931930 into kubernetes:master Apr 9, 2018
@hzxuzhonghu hzxuzhonghu deleted the corev1-api-delete branch April 10, 2018 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@justinsb justinsb Awaiting requested review from justinsb

@krousey krousey Awaiting requested review from krousey

@markturansky markturansky Awaiting requested review from markturansky

Assignees

@liggitt liggitt

@smarterclayton smarterclayton

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hzxuzhonghu @deads2k @smarterclayton @k8s-ci-robot @fejta-bot @k8s-github-robot @liggitt