Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate PSP-related types in extensions/v1beta1 #61777

Merged
merged 2 commits into from
Mar 28, 2018
Merged

Deprecate PSP-related types in extensions/v1beta1 #61777

merged 2 commits into from
Mar 28, 2018

Conversation

php-coder
Copy link
Contributor

What this PR does / why we need it:
This PR deprecates PSP-related types in extensions/v1beta1 API Group and suggests to use their versions from policy/v1beta1. This is a part of PSP migration away from extensions API Group.

Which issue(s) this PR fixes:
Addressed to kubernetes/enhancements#5

@k8s-ci-robot
Copy link
Contributor

@php-coder: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 27, 2018
@k8s-ci-robot k8s-ci-robot requested review from mikedanese and ncdc March 27, 2018 14:48
@php-coder
Copy link
Contributor Author

/release-note-none
/sig auth

PTAL @kubernetes/sig-auth-api-reviews
CC @simo5

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 27, 2018
@php-coder
Copy link
Contributor Author

/assign @liggitt

liggitt
liggitt reviewed Mar 27, 2018
View reviewed changes
staging/src/k8s.io/api/extensions/v1beta1/types.go Outdated
@@ -864,6 +864,7 @@ type ReplicaSetCondition struct {

// PodSecurityPolicy governs the ability to make requests that affect the Security Context
// that will be applied to a pod and container.
// Deprecated: use PodSecurityPolicy from policy/v1beta1 API Group instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omit the version... we don't want to need to update this when it gets promoted in the policy group

@php-coder php-coder force-pushed the psp_deprecate_api_in_extensions branch from c526143 to 13ae1d1 Compare March 27, 2018 15:47
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 27, 2018
@php-coder php-coder force-pushed the psp_deprecate_api_in_extensions branch from 13ae1d1 to 28dc723 Compare March 27, 2018 17:18
@php-coder php-coder force-pushed the psp_deprecate_api_in_extensions branch from 28dc723 to 9223f0d Compare March 27, 2018 18:20
@php-coder
Copy link
Contributor Author

/retest

@php-coder
Copy link
Contributor Author

/test pull-kubernetes-integration

@php-coder
Copy link
Contributor Author

@liggitt Thanks! Your comment was addressed and it's green. PTAL.

@liggitt
Copy link
Member

liggitt commented Mar 28, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, php-coder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 61842, 61477, 61777). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 8b6a4e1 into kubernetes:master Mar 28, 2018
@php-coder php-coder deleted the psp_deprecate_api_in_extensions branch March 29, 2018 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@mikedanese mikedanese Awaiting requested review from mikedanese

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@php-coder @k8s-ci-robot @liggitt @k8s-github-robot