add udev to hyperkube and bump versions by rphillips · Pull Request #61357 · kubernetes/kubernetes

rphillips · 2018-03-19T15:14:31Z

What this PR does / why we need it: Adds udev to the hyperkube to fix GCE and OpenStack volume mounts.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #61356
Fixes #43515
Fixes coreos/bugs#2385

Special notes for your reviewer:

/cc @kubernetes/sig-node-bugs @kubernetes/sig-node-pr-reviews
/cc @ixdy

Release note:

Add ipset and udevadm to the hyperkube base image.

rphillips · 2018-03-19T21:34:41Z

/cc @lavalamp

rphillips · 2018-03-20T18:54:03Z

cc @kubernetes/sig-storage-pr-reviews

ixdy · 2018-03-21T00:29:11Z

lgtm, I'll work on getting this built/pushed tomorrow.

do we have any e2e testing around hyperkube? finding all of these issues through bug reports is getting kinda old...

dims · 2018-03-21T00:37:36Z

@ixdy we have (ci|pull)-kubernetes-local-e2e jobs that use hyperkube (DIND environment). I am planning to reuse that harness (kubetest+local-up-cluster) to test OpenStack as well (under OpenLab https://openlabtesting.org/) and post results back to our dashboards. @hogepodge @codebauss @kiwik are all going to be involved in this effort. Another angle to this is to find/add e2e tests that are specific to cloud providers (same tests against multiple providers) as part of the cloud provider wg effort too. There are a few of us interested in that.

ixdy · 2018-03-21T21:44:20Z

/assign

ixdy

images pushed. please update Bazel WORKSPACE dependency, and then this LGTM.

ixdy · 2018-03-21T23:15:28Z

build/root/WORKSPACE

please update this to sha256:cc782ed16599000ca4c85d47ec6264753747ae1e77520894dca84b104a7621e2

rphillips · 2018-03-23T14:27:00Z

@ixdy thanks! pushed the updated hash

ixdy · 2018-03-23T19:23:54Z

/lgtm

ixdy · 2018-03-23T19:24:20Z

/assign @mikedanese

k8s-ci-robot · 2018-03-28T08:50:18Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ixdy · 2018-03-28T15:55:54Z

not sure why the CLA bot is suddenly unhappy. did you rebase and change your email or something?

rphillips · 2018-03-28T16:48:29Z

@ixdy sorry, migrated the CLA bot to my new red hat address. I rewrote the commit. Should be good to go.

ixdy · 2018-03-28T17:49:45Z

/lgtm

mikedanese · 2018-03-28T18:06:00Z

/approve

k8s-ci-robot · 2018-03-28T18:06:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, mikedanese, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~build/OWNERS~~ [ixdy,mikedanese]
~~cluster/OWNERS~~ [mikedanese]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ixdy · 2018-03-28T18:07:49Z

cluster/images/hyperkube/Makefile

 OUT_DIR?=_output
 HYPERKUBE_BIN?=$(OUT_DIR)/dockerized/bin/linux/$(ARCH)/hyperkube

-BASEIMAGE=k8s.gcr.io/debian-hyperkube-base-$(ARCH):0.8


what happened to 0.9?

oh, oops: #57648 (comment)

k8s-github-robot · 2018-03-28T20:52:12Z

Automatic merge from submit-queue (batch tested with PRs 61848, 61188, 56363, 61357, 61838). If you want to cherry-pick this change to another branch, please follow the instructions here.

rphillips · 2018-03-28T21:12:44Z

Got a cherry pick up for 1.10: #61861

ixdy · 2018-03-28T21:15:07Z

/release-note

k8s-ci-robot · 2018-03-28T21:15:08Z

@ixdy: the /release-note and /release-note-action-required commands have been deprecated.
Please edit the release-note block in the PR body text to include the release note. If the release note requires additional action include the string action required in the release note. For example:

```release-note
Some release note with action required.
```

Details

In response to this:

/release-note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ixdy · 2018-03-28T21:15:31Z

it occurs to me that a release note is probably a good idea?

ixdy · 2018-03-28T21:15:59Z

I apparently don't understand how to use the release note plugin anymore, though.

rphillips · 2018-03-28T21:20:25Z

@ixdy I updated the release note in the PR... I am not sure if I have to do anything, since it was after the merge.

…357-upstream-release-1.10 Automatic merge from submit-queue. Automated cherry pick of #61357: add udev to hyperkube and bump versions Cherry pick of #61357 on release-1.10. #61357: add udev to hyperkube and bump versions

…357-upstream-release-1.9 Automatic merge from submit-queue. Automated cherry pick of #61357: add udev to hyperkube and bump versions Cherry pick of #61357 on release-1.9. #61357: add udev to hyperkube and bump versions

k8s-ci-robot requested a review from ixdy March 19, 2018 15:14

k8s-ci-robot requested a review from lavalamp March 19, 2018 21:34

k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Mar 20, 2018

k8s-ci-robot assigned ixdy Mar 21, 2018

ixdy reviewed Mar 21, 2018

View reviewed changes

rphillips force-pushed the fixes/add_udev_to_hyperkube branch from 3930b68 to fee9c9e Compare March 23, 2018 14:26

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2018

k8s-ci-robot assigned mikedanese Mar 23, 2018

k8s-ci-robot removed the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 28, 2018

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 28, 2018

add udev to hyperkube and bump versions

2966211

rphillips force-pushed the fixes/add_udev_to_hyperkube branch from fee9c9e to 2966211 Compare March 28, 2018 16:47

k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 28, 2018

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 28, 2018

This was referenced Mar 28, 2018

Bump debian-hyperkube-base to 0.9 for hyperkube-amd64 to pick up ipset #61771

Closed

CoreOS hyperkube v1.9.0_coreos.0: No ipset utility, IPVS proxy mode fails coreos/coreos-kubernetes#915

Closed

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2018

ixdy mentioned this pull request Mar 28, 2018

Add ixdy, luxas, and mikedanese as OWNERS of hyperkube image #61848

Merged

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2018

ixdy reviewed Mar 28, 2018

View reviewed changes

k8s-github-robot merged commit ee99895 into kubernetes:master Mar 28, 2018

rphillips mentioned this pull request Mar 28, 2018

Automated cherry pick of #61357: add udev to hyperkube and bump versions #61861

Merged

k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 28, 2018

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 28, 2018

dims mentioned this pull request Apr 5, 2018

hyperkube:v1.10.0 kube-proxy throwing ipset errors on startup #61750

Closed

rphillips mentioned this pull request Apr 23, 2018

Automated cherry pick of #61357: add udev to hyperkube and bump versions #63020

Merged

Conversation

rphillips commented Mar 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rphillips commented Mar 19, 2018

Uh oh!

rphillips commented Mar 20, 2018

Uh oh!

ixdy commented Mar 21, 2018

Uh oh!

dims commented Mar 21, 2018

Uh oh!

ixdy commented Mar 21, 2018

Uh oh!

ixdy left a comment

Choose a reason for hiding this comment

Uh oh!

ixdy Mar 21, 2018

Choose a reason for hiding this comment

Uh oh!

rphillips commented Mar 23, 2018

Uh oh!

ixdy commented Mar 23, 2018

Uh oh!

ixdy commented Mar 23, 2018

Uh oh!

k8s-ci-robot commented Mar 28, 2018

Uh oh!

ixdy commented Mar 28, 2018

Uh oh!

rphillips commented Mar 28, 2018

Uh oh!

ixdy commented Mar 28, 2018

Uh oh!

mikedanese commented Mar 28, 2018

Uh oh!

k8s-ci-robot commented Mar 28, 2018

Uh oh!

ixdy Mar 28, 2018

Choose a reason for hiding this comment

Uh oh!

ixdy Mar 28, 2018

Choose a reason for hiding this comment

Uh oh!

k8s-github-robot commented Mar 28, 2018

Uh oh!

rphillips commented Mar 28, 2018

Uh oh!

ixdy commented Mar 28, 2018

Uh oh!

k8s-ci-robot commented Mar 28, 2018

Uh oh!

ixdy commented Mar 28, 2018

Uh oh!

ixdy commented Mar 28, 2018

Uh oh!

rphillips commented Mar 28, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rphillips commented Mar 19, 2018 •

edited

Loading