Client-go raises error on duplicated name in kubeconfig #60464
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
release-note
|
/lgtm /approve |
|
/assign @krousey for approval |
|
@roycaihw: GitHub didn't allow me to assign the following users: for, approval. Note that only kubernetes members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@caesarxuchao for approval |
| } | ||
|
|
||
| _, err = LoadFromFile(configFile.Name()) | ||
| if err == nil { |
There was a problem hiding this comment.
Also check the error message? Same for the other tests.
| - cluster: | ||
| api-version: v1 | ||
| server: https://kubernetes.default.svc:443 | ||
| certificate-authority: /var/run/secrets/kubernetes.io/serviceaccount/ca.crt |
There was a problem hiding this comment.
Could you change the api-version, server, and certificate-authority? We want to make sure an error is returned even if name is the only duplicate bit.
Same for the other tests.
for NamedCluster, NamedContext, NamedUser, NamedExtension
|
@caesarxuchao Updated |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caesarxuchao, mbohlool, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest Review the full test history for this PR. Silence the bot with an |
1 similar comment
|
/retest Review the full test history for this PR. Silence the bot with an |
|
Automatic merge from submit-queue (batch tested with PRs 63598, 63913, 63459, 63963, 60464). If you want to cherry-pick this change to another branch, please follow the instructions here. |
(for NamedCluster, NamedContext, NamedUser, NamedExtension)
What this PR does / why we need it:
Client should detect duplicated name when loading
name-valuebased lists in kubeconfig:users,clusters,contexts. Currently if there are multiple value with same name,client-pythonwill pick the first one, whileclient-gowill pick the last.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):ref: kubernetes-client/python#445, kubernetes-client/python-base#47
Special notes for your reviewer:
Release note:
/sig api-machinery
cc @brendandburns @mbohlool