Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move volume scheduling and local storage to beta #59391

Merged
merged 5 commits into from
Feb 20, 2018
Merged

Move volume scheduling and local storage to beta #59391

merged 5 commits into from
Feb 20, 2018

Conversation

msau42
Copy link
Member

@msau42 msau42 commented Feb 6, 2018 •
edited
Loading

What this PR does / why we need it:

  • Move the feature gates and APIs for volume scheduling and local storage to beta
  • Update tests to use the beta fields
    @kubernetes/sig-storage-pr-reviews

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #59390

Special notes for your reviewer:

Release note:

ACTION REQUIRED: VolumeScheduling and LocalPersistentVolume features are beta and enabled by default.  The PersistentVolume NodeAffinity alpha annotation is deprecated and will be removed in a future release.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 6, 2018
@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Feb 6, 2018
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2018
@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 6, 2018
@lichuqiang
Copy link
Contributor

/cc

@msau42 msau42 changed the title WIP: Move volume scheduling and local storage to beta Move volume scheduling and local storage to beta Feb 6, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2018
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2018
@msau42
Copy link
Member Author

msau42 commented Feb 17, 2018

I rebased and also added a commit to update volume predicate invalidation for the new NodeAffinity field.

/assign @resouer @bsalamat
for scheduler review

@msau42
Copy link
Member Author

msau42 commented Feb 17, 2018

Nevermind, ignore my last comment. There is validation that the PV.NodeAffinity field cannot be changed. So there is no need to update predicate invalidation for PV update. I removed the last commit.

@jsafrane
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2018
thockin
thockin reviewed Feb 20, 2018
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify and handle the transitional case where both are set. The alpha should win.

pkg/apis/core/types.go
// VolumeNodeAffinity defines constraints that limit what nodes this volume can be accessed from.
type VolumeNodeAffinity struct {
// Required specifies hard node constraints that must be met.
Required *NodeSelector
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, disallow field updates until/unless you know exactly what they are for.

pkg/apis/core/validation/validation.go
@@ -1497,6 +1500,10 @@ func ValidatePersistentVolume(pv *core.PersistentVolume) field.ErrorList {
nodeAffinitySpecified, errs := validateStorageNodeAffinityAnnotation(pv.ObjectMeta.Annotations, metaPath.Child("annotations"))
allErrs = append(allErrs, errs...)

volumeNodeAffinitySpecified, errs := validateVolumeNodeAffinity(pv.Spec.NodeAffinity, specPath.Child("nodeAffinity"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if both this field and the older annotation are set?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current code will evaluate both if both are set, but it can be changed to have beta be ignored if alpha is set.

pkg/apis/core/validation/validation.go
@@ -4952,6 +4963,27 @@ func validateStorageNodeAffinityAnnotation(annotations map[string]string, fldPat
return policySpecified, allErrs
}

// validateVolumeNodeAffinity tests that the PersistentVolume.NodeAffinity has valid data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document the bool return

@msau42
Disallow setting both alpha and beta PV nodeAffinity
a6a2256 
Allow setting PV nodeAffinity if previously unset
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2018
@thockin
Copy link
Member

thockin commented Feb 20, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, msau42, thockin, verult

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 6ba4696 into kubernetes:master Feb 20, 2018
@NickrenREN NickrenREN mentioned this pull request Feb 22, 2018
Closed
This was referenced Feb 27, 2018
Closed
Closed
@shyamjvs shyamjvs mentioned this pull request Feb 28, 2018
Closed
3 tasks
@NickrenREN NickrenREN mentioned this pull request Mar 3, 2018
Closed
3 tasks
@tengqm tengqm mentioned this pull request Mar 29, 2018
Closed
2 tasks
@ryanwalls
Copy link

Is there documentation for how to use persistent local storage? Can't seem to find anything.

@ku-s-h
Copy link

ku-s-h commented Apr 16, 2018 •
edited
Loading

@ryanwalls https://github.com/kubernetes-incubator/external-storage/tree/master/local-volume

@ryanwalls
Copy link

@mightwork FYI, get a 404 on that link.

@msau42
Copy link
Member Author

msau42 commented Apr 17, 2018

The official kubernetes documentation has a link to the external-storage walkthrough as well

@ku-s-h
Copy link

ku-s-h commented Apr 17, 2018

@ryanwalls my bad. Updated with the correct link.

@Ritikaa96 Ritikaa96 mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@verult verult verult left review comments

@jsafrane jsafrane jsafrane left review comments

@luxas luxas luxas left review comments

@thockin thockin thockin left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@childsb childsb Awaiting requested review from childsb

@copejon copejon Awaiting requested review from copejon

@deads2k deads2k Awaiting requested review from deads2k

@erictune erictune Awaiting requested review from erictune

@gmarek gmarek Awaiting requested review from gmarek

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@nikhiljindal nikhiljindal Awaiting requested review from nikhiljindal

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@yifan-gu yifan-gu Awaiting requested review from yifan-gu

@lichuqiang lichuqiang Awaiting requested review from lichuqiang

Assignees

@liggitt liggitt

@verult verult

@resouer resouer

@jsafrane jsafrane

@thockin thockin

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move volume scheduling and local storage to beta