Enable list option modification when create list watch #57508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/assign @ncdc |
k8s-ci-robot
added
lgtm
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/joke |
|
@chechiachang: Why do bees hum? Because they don't know the words. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@chechiachang This is very helpful for me!! |
|
@kairen Glad to help:) |
|
@ncdc Could you take another look at this PR? Thanks. |
sttts
reviewed
Jan 2, 2018
| } | ||
|
|
||
| // NewListWatchFromClientWithSelectors creates a new ListWatch from the specified client, resource, namespace, field selector, and label selector. | ||
| func NewListWatchFromClientWithSelectors(c Getter, resource string, namespace string, fieldSelector fields.Selector, labelSelector labels.Selector) *ListWatch { |
There was a problem hiding this comment.
How about a decorator like WithSelectors(NewListWatchFromClient(...))? All these ListOptions modifications are orthogonal to the actual ListWatch construction. ListOptions have even more fields. We don't want to add yet another constructor after this one. Decorators are more natural.
There was a problem hiding this comment.
Sounds much better. Let me rewrite this function. @sttts thanks
chechiachang
force-pushed
the
enable-label-selector-for-client-go-listwatch
branch
from
c940778 to
d171b3f
Compare
k8s-github-robot
removed
the
lgtm
chechiachang
force-pushed
the
enable-label-selector-for-client-go-listwatch
branch
from
d171b3f to
8d9d993
Compare
k8s-ci-robot
added
size/S
chechiachang
changed the title
chechiachang
force-pushed
the
enable-label-selector-for-client-go-listwatch
branch
from
8d9d993 to
4f45d0c
Compare
|
@sttts Could you take another look at this PR? Any comment will be very appreciated. |
sttts
reviewed
Jan 5, 2018
| // NewListWatchFromClientWithSelectors creates a new ListWatch from the specified client, resource, namespace, and option modifier. | ||
| // Option modifier is a function takes a ListOptions and modifies the consumed ListOptions. Provide customized modifier function | ||
| // to apply modification to ListOptions with a field selector, a label selector, or any other desired options. | ||
| func NewListWatchFromClientWithModifier(c Getter, resource string, namespace string, optionsModifier func(options *metav1.ListOptions)) *ListWatch { |
There was a problem hiding this comment.
To be inline with the naming of filtered informers (NewFilteredSharedInformerFactory), let's call it NewFilteredListWatchFromClient.
chechiachang
force-pushed
the
enable-label-selector-for-client-go-listwatch
branch
from
4f45d0c to
5fa2263
Compare
chechiachang
force-pushed
the
enable-label-selector-for-client-go-listwatch
branch
from
5fa2263 to
2780b8f
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chechiachang, ncdc, spiffxp, sttts Associated issue requirement bypassed by: sttts The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
|
lgtm. Thank you! |
asymmetric
pushed a commit
to kinvolk-archives/habitat-operator
that referenced
this pull request
Apr 24, 2018
The `NewFilteredListWatchFromClient` function introduced in client-go v7.0.0 allows us to filter based on custom fields/labels, therefore we don't need our custom implementation of this functionality. The function was introduced [here](kubernetes/kubernetes#57508) Signed-off-by: Lorenzo Manacorda <[email protected]>
asymmetric
pushed a commit
to kinvolk-archives/habitat-operator
that referenced
this pull request
Apr 24, 2018
The `NewFilteredListWatchFromClient` function introduced in client-go v7.0.0 allows us to filter based on custom fields/labels, therefore we don't need our custom implementation of this functionality. The function was introduced [here](kubernetes/kubernetes#57508) Signed-off-by: Lorenzo Manacorda <[email protected]>
asymmetric
pushed a commit
to kinvolk-archives/habitat-operator
that referenced
this pull request
Apr 24, 2018
The `NewFilteredListWatchFromClient` function introduced in client-go v7.0.0 allows us to filter based on custom fields/labels, therefore we don't need our custom implementation of this functionality. The function was introduced [here](kubernetes/kubernetes#57508) Signed-off-by: Lorenzo Manacorda <[email protected]>
asymmetric
pushed a commit
to kinvolk-archives/habitat-operator
that referenced
this pull request
Apr 24, 2018
The `NewFilteredListWatchFromClient` function introduced in client-go v7.0.0 allows us to filter based on custom fields/labels, therefore we don't need our custom implementation of this functionality. The function was introduced [here](kubernetes/kubernetes#57508) Signed-off-by: Lorenzo Manacorda <[email protected]>
asymmetric
pushed a commit
to kinvolk-archives/habitat-operator
that referenced
this pull request
Apr 24, 2018
The `NewFilteredListWatchFromClient` function introduced in client-go v7.0.0 allows us to filter based on custom fields/labels, therefore we don't need our custom implementation of this functionality. The function was introduced [here](kubernetes/kubernetes#57508) Signed-off-by: Lorenzo Manacorda <[email protected]>
asymmetric
pushed a commit
to kinvolk-archives/habitat-operator
that referenced
this pull request
Apr 25, 2018
The `NewFilteredListWatchFromClient` function introduced in client-go v7.0.0 allows us to filter based on custom fields/labels, therefore we don't need our custom implementation of this functionality. The function was introduced [here](kubernetes/kubernetes#57508) Signed-off-by: Lorenzo Manacorda <[email protected]>
asymmetric
pushed a commit
to kinvolk-archives/habitat-operator
that referenced
this pull request
Apr 25, 2018
The `NewFilteredListWatchFromClient` function introduced in client-go v7.0.0 allows us to filter based on custom fields/labels, therefore we don't need our custom implementation of this functionality. The function was introduced [here](kubernetes/kubernetes#57508) Signed-off-by: Lorenzo Manacorda <[email protected]>
asymmetric
pushed a commit
to kinvolk-archives/habitat-operator
that referenced
this pull request
May 2, 2018
The `NewFilteredListWatchFromClient` function introduced in client-go v7.0.0 allows us to filter based on custom fields/labels, therefore we don't need our custom implementation of this functionality. The function was introduced [here](kubernetes/kubernetes#57508) Signed-off-by: Lorenzo Manacorda <[email protected]>
asymmetric
pushed a commit
to kinvolk-archives/habitat-operator
that referenced
this pull request
May 2, 2018
The `NewFilteredListWatchFromClient` function introduced in client-go v7.0.0 allows us to filter based on custom fields/labels, therefore we don't need our custom implementation of this functionality. The function was introduced [here](kubernetes/kubernetes#57508) Signed-off-by: Lorenzo Manacorda <[email protected]>
asymmetric
pushed a commit
to kinvolk-archives/habitat-operator
that referenced
this pull request
May 7, 2018
The `NewFilteredListWatchFromClient` function introduced in client-go v7.0.0 allows us to filter based on custom fields/labels, therefore we don't need our custom implementation of this functionality. The function was introduced [here](kubernetes/kubernetes#57508) Signed-off-by: Lorenzo Manacorda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
metav1.ListOptions support both field selector and label selector, but the current NewListWatchFromClient in client-go only support field selector.
It would be helpful to use label selector in client-go.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: