Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client-go: Fix broken TCP6 listen for port forwarding #57457

Merged
merged 1 commit into from
Jan 31, 2018
Merged

client-go: Fix broken TCP6 listen for port forwarding #57457

merged 1 commit into from
Jan 31, 2018

Conversation

vfreex
Copy link
Contributor

@vfreex vfreex commented Dec 20, 2017

What this PR does / why we need it:
The IPV6 loopback address ::1 is enclosed in square brackets twice,
which cause a failure to listen on the TCP6 port.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:

Release note:

Fix an issue where port forwarding doesn't forward local TCP6 ports to the pod

/area ipv6
/sig cli

@vfreex
client-go: Fix broken TCP6 listen for port forwarding
942ff28 
The IPV6 loopback address `::1` is enclosed in square brackets twice,
which cause a failure to listen on the TCP6 port.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ipv6 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 20, 2017
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 20, 2017
@dims
Copy link
Member

dims commented Dec 20, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 20, 2017
@jsafrane
Copy link
Member

/assign @sttts
/unassign
I know very little about client-go

@k8s-ci-robot k8s-ci-robot assigned sttts and unassigned jsafrane Jan 30, 2018
@sttts
Copy link
Contributor

sttts commented Jan 30, 2018

/assign @frobware

Andrew is the tcp6 expert if I remember right.

@k8s-ci-robot
Copy link
Contributor

@sttts: GitHub didn't allow me to assign the following users: frobware.

Note that only kubernetes members and repo collaborators can be assigned.

In response to this:

/assign @frobware

Andrew is the tcp6 expert if I remember right.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

frobware
frobware reviewed Jan 30, 2018
View reviewed changes
Copy link
Contributor

@frobware frobware left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as this eventually calls net.JoinHostPort() which itself will add "[<address>]:".

@sttts
Copy link
Contributor

sttts commented Jan 30, 2018

/approve no-issue

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2018
frobware
frobware reviewed Jan 30, 2018
View reviewed changes
Copy link
Contributor

@frobware frobware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, sttts, vfreex

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@frobware: changing LGTM is restricted to assignees, and only kubernetes org members may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Contributor

sttts commented Jan 30, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2018
@vfreex
Copy link
Contributor Author

vfreex commented Jan 31, 2018

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit a241087 into kubernetes:master Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frobware frobware frobware left review comments

Assignees

@justinsb justinsb

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipv6 cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vfreex @dims @jsafrane @sttts @k8s-ci-robot @k8s-github-robot @frobware @justinsb