Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make HugePages const name consistent. #54748

Merged
merged 1 commit into from
Oct 30, 2017
Merged

Make HugePages const name consistent. #54748

merged 1 commit into from
Oct 30, 2017

Conversation

xiangpengzhao
Copy link
Contributor

What this PR does / why we need it:
Make HugePages const name in v1 be consistent with the name in api.

kubernetes/pkg/api/types.go

Line 686 in f9e6142

StorageMediumHugePages StorageMedium = "HugePages" // use hugepages

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 28, 2017
dixudx
dixudx reviewed Oct 29, 2017
View reviewed changes
staging/src/k8s.io/api/core/v1/types.go
@@ -989,7 +989,7 @@ type StorageMedium string
const (
StorageMediumDefault StorageMedium = "" // use whatever the default is for the node
StorageMediumMemory StorageMedium = "Memory" // use memory (tmpfs)
StorageMediumHugepages StorageMedium = "HugePages" // use hugepages
StorageMediumHugePages StorageMedium = "HugePages" // use hugepages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply a rename, StorageMediumHugepages-> StorageMediumHugePages, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't it break API compatibility? Do we guarantee any in k8s.i/api?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it breaks API compatibility. It just change the const name. It doesn't change the actual name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Const name is API. Changing its name breaks builds to anyone who imported k8s.i/api and used api.StorageMediumHugepages in his go code. Question is if we support k8s.i/api stability.

@kubernetes/sig-api-machinery-pr-reviews

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't. In major updates we have a number of changes usually which breaks compilation of 3rdparty code.

@jsafrane
Copy link
Member

/retest
"Error checking queue status"

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Oct 30, 2017
@sttts
Copy link
Contributor

sttts commented Oct 30, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2017
@sttts
Copy link
Contributor

sttts commented Oct 30, 2017

/assign @thockin

For approval.

@thockin
Copy link
Member

thockin commented Oct 30, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts, thockin, xiangpengzhao

Associated issue requirement bypassed by: thockin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2017
@lavalamp
Copy link
Member

Removing the sig/api-machinery label: SIG API Machinery doesn't own the contents of the API.

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 30, 2017
@lavalamp lavalamp removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Oct 30, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 54761, 54748, 53991, 54485, 46951). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit cdc92e1 into kubernetes:master Oct 30, 2017
@xiangpengzhao xiangpengzhao deleted the fix-const branch October 30, 2017 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

@jsafrane jsafrane jsafrane left review comments

@dixudx dixudx dixudx left review comments

Assignees

@sttts sttts

@jsafrane jsafrane

@thockin thockin

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@xiangpengzhao @jsafrane @sttts @thockin @k8s-github-robot @lavalamp @dixudx @saad-ali @k8s-ci-robot