kubectl: Remove swagger 1.2 entirely. #53441
Conversation
k8s-ci-robot
added
release-note-none
apelisse
force-pushed
the
completely-remove-swagger
branch
from
1ffe78f to
d39bf6c
Compare
| @@ -336,41 +327,6 @@ func (d *DiscoveryClient) ServerVersion() (*version.Info, error) { | |||
| return &info, nil | |||
| } | |||
|
|
|||
| // SwaggerSchema retrieves and parses the swagger API schema the server supports. | |||
| // TODO: Replace usages with Open API. Tracked in https://github.com/kubernetes/kubernetes/issues/44589 | |||
| func (d *DiscoveryClient) SwaggerSchema(version schema.GroupVersion) (*swagger.ApiDeclaration, error) { | |||
There was a problem hiding this comment.
We don't know if there is any client-go user depends on swagger 1.2. Could you send an email to kubernetes-dev to ask if anyone objects remove swagger 1.2 from client-go? We can proceed if no one objects.
There was a problem hiding this comment.
Thanks for looking at it! Yeah, doing it right now.
There was a problem hiding this comment.
No news? Shall we proceed?
apelisse
force-pushed
the
completely-remove-swagger
branch
from
d39bf6c to
32990bf
Compare
| ) | ||
|
|
||
| // InvalidTypeError records information about an invalid type. | ||
| type InvalidTypeError struct { |
There was a problem hiding this comment.
A little bit surprised that we have an error type that's only used by the swagger.
There was a problem hiding this comment.
This are just convenience type used by Swagger 1.2. OpenAPi validation has redefined these types ...
|
lgtm. @apelisse could you get someone from the kubectl side to approve the change as well? |
apelisse
force-pushed
the
completely-remove-swagger
branch
from
32990bf to
d1ce363
Compare
|
/approve |
1 similar comment
|
/approve |
k8s-github-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, monopole, pwittrock Associated issue: 44589 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/retest Review the full test history for this PR. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
Remove dead code since nothing is using swagger 1.2 anymore. This doesn't change any feature, it's just removing unused code.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): Follow up on #44589Special notes for your reviewer:
Release note: