Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roundtrip: fix error messages #51204

Merged
merged 1 commit into from
Aug 24, 2017
Merged

roundtrip: fix error messages #51204

merged 1 commit into from
Aug 24, 2017

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Aug 23, 2017

The error messages had some typos due to which it generated false positives. (encountered in #47263)

Release note:

NONE

/cc @sttts

@k8s-ci-robot k8s-ci-robot requested a review from sttts August 23, 2017 16:31
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 23, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @nikhita. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 23, 2017
@ncdc
Copy link
Member

ncdc commented Aug 23, 2017

/assign @sttts
/unassign

@sttts
Copy link
Contributor

sttts commented Aug 23, 2017

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot assigned sttts and unassigned ncdc Aug 23, 2017
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, sttts

Associated issue: 47263

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2017
@sttts
Copy link
Contributor

sttts commented Aug 23, 2017

/assign @deads2k

For approval.

@sttts
Copy link
Contributor

sttts commented Aug 23, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 23, 2017
@nikhita
Copy link
Member Author

nikhita commented Aug 23, 2017

/retest

2 similar comments
@nikhita
Copy link
Member Author

nikhita commented Aug 23, 2017

/retest

@nikhita
Copy link
Member Author

nikhita commented Aug 23, 2017

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 47115, 51196, 51204, 51208, 51206)

@k8s-github-robot k8s-github-robot merged commit 761fb34 into kubernetes:master Aug 24, 2017
@andrewsykim andrewsykim mentioned this pull request Aug 25, 2017
Merged
@nikhita nikhita mentioned this pull request Aug 28, 2017
Merged
13 tasks
@nikhita nikhita deleted the fix-roundtrip-errors branch August 28, 2017 21:19
k8s-github-robot pushed a commit that referenced this pull request Aug 30, 2017
Merge pull request #47263 from nikhita/crd-01-validation-types
4457e43 
Automatic merge from submit-queue

apiextensions: validation for customresources

- [x] Add types for validation of CustomResources
- [x] Fix conversion-gen: #49747
- [x] Fix defaulter-gen: kubernetes/gengo#61
- [x] Convert to OpenAPI types
- [x] Validate CR using go-openapi
- [x] Validate CRD Schema
- [x] Add integration tests
- [x] Fix round trip tests: #51204 
- [x] Add custom fuzzer functions
- [x] Add custom conversion functions
- [x] Fix data race while updating CRD: #50098 
- [x] Add feature gate for CustomResourceValidation
- [x] Fix protobuf generation

Proposal: kubernetes/community#708
Additional discussion: #49879, #50625

**Release note**:

```release-note
Add validation for CustomResources via JSON Schema.
```

/cc @sttts @deads2k
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts Awaiting requested review from sttts

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nikhita @k8s-ci-robot @ncdc @sttts @k8s-github-robot @thockin @deads2k