Skip to content

pass nodename in join checks #49073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stevenbower wants to merge 1 commit into from
Closed

pass nodename in join checks #49073

stevenbower wants to merge 1 commit into from

Conversation

@stevenbower
Copy link

@stevenbower stevenbower commented Jul 18, 2017 •
edited by luxas
Loading

Fix preflight HostnameCheck when running kubeadm in join mode

fixes kubernetes/kubeadm#347

kubeadm: Fix passing the node name to `kubeadm join` preflight checks

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 18, 2017

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 18, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 18, 2017

Hi @stevenbower. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jul 18, 2017
@stevenbower
Copy link
Author

stevenbower commented Jul 18, 2017

Added CLA

@timothysc timothysc removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 18, 2017
@timothysc timothysc added this to the v1.8 milestone Jul 18, 2017
@timothysc timothysc assigned luxas and unassigned timothysc Jul 18, 2017
@timothysc
Copy link
Contributor

timothysc commented Jul 18, 2017

/assign @luxas

@luxas
Copy link
Member

luxas commented Jul 18, 2017

Thanks @stevenbower! Happy first contribution!

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2017
@k8s-github-robot
Copy link

k8s-github-robot commented Jul 18, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luxas, stevenbower

Associated issue: 347

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jul 18, 2017
@luxas luxas added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Jul 18, 2017
@luxas luxas modified the milestones: v1.7, v1.8 Jul 18, 2017
@luxas
Copy link
Member

luxas commented Jul 18, 2017

@k8s-bot I signed it!

@luxas luxas mentioned this pull request Jul 18, 2017
Merged
@luxas
Copy link
Member

luxas commented Jul 18, 2017

/retest

@luxas luxas added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 18, 2017
@wojtek-t wojtek-t closed this Jul 18, 2017
@wojtek-t wojtek-t reopened this Jul 18, 2017
@luxas
Copy link
Member

luxas commented Jul 18, 2017

@stevenbower Are you sure you have signed the CLA for your current Github ID and the email address you attached to this commit? The bot doesn't seem to pick it up somehow...

k8s-github-robot pushed a commit that referenced this pull request Jul 19, 2017
Merge pull request #49094 from luxas/automated-cherry-pick-of-#49017-#…
c8f01bb 
…49073-upstream-release-1.7

Automatic merge from submit-queue

Automated cherry pick of #49017 #49073

Cherry pick of #49017 #49073 on release-1.7.

#49017: kubeadm: Make kube-proxy tolerate the uninitialized cloud
#49073: pass nodename in join checks
@stevenbower
Copy link
Author

stevenbower commented Jul 24, 2017

Will double check this evening...

@k8s-github-robot
Copy link

k8s-github-robot commented Jul 25, 2017

/lgtm cancel //PR changed after LGTM, removing LGTM. @justinsb @luxas @stevenbower

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2017
@stevenbower
Copy link
Author

stevenbower commented Jul 25, 2017

Think i sorted the CLA issue, how do we get the cla check to re-run?

@luxas luxas closed this Jul 25, 2017
@luxas luxas reopened this Jul 25, 2017
@luxas
Copy link
Member

luxas commented Jul 25, 2017

Is [email protected] the email you have a CLA for?

@luxas
Copy link
Member

luxas commented Jul 25, 2017

@stevenbower Please comment @k8s-bot I signed it!

@stevenbower
Copy link
Author

stevenbower commented Jul 28, 2017

@k8s-bot I signed it!

@erhudy erhudy mentioned this pull request Jul 28, 2017
Closed
@luxas luxas mentioned this pull request Jul 31, 2017
Merged
@k8s-github-robot
Copy link

k8s-github-robot commented Aug 1, 2017

@stevenbower PR needs rebase

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2017
@luxas
Copy link
Member

luxas commented Aug 2, 2017

I'm very sorry about your CLA not being recognized, can you please reach out to the CLA helpdesk?
In the meantime, I had to choose #49825 instead, due to that it both required changes and that it was ready to merge by the deadline of last Monday.

I'd love to have you contributing more in the future, but the CLA thing needs to be solved first I'm afraid.
Please reach out to me if you have further questions.

@luxas luxas closed this Aug 2, 2017
@wojtek-t wojtek-t removed cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@justinsb justinsb

@luxas luxas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.7

Development

Successfully merging this pull request may close these issues.

kubeadm join failing preflight checks

7 participants

@stevenbower @k8s-ci-robot @timothysc @luxas @k8s-github-robot @justinsb @wojtek-t