Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove tpr api access #48353

Merged
merged 1 commit into from
Jul 5, 2017
Merged

remove tpr api access #48353

merged 1 commit into from
Jul 5, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jun 30, 2017 •
edited by enisoc
Loading

xref #48152

TPR tentacles go pretty deep. This gets us started by removing API access and we'll move down from there.

@kubernetes/sig-api-machinery-misc
@ironcladlou this should free up the GC implementation since TPRs will no longer be present and failing.

The deprecated ThirdPartyResource (TPR) API has been removed. To avoid losing your TPR data, you must [migrate to CustomResourceDefinition](https://kubernetes.io/docs/tasks/access-kubernetes-api/migrate-third-party-resource/) before upgrading.

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 30, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deads2k
We suggest the following additional approver: erictune

Assign the PR to them by writing /assign @erictune in a comment when ready.

Associated issue: 48152

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Jun 30, 2017
@enisoc
Copy link
Member

enisoc commented Jun 30, 2017

LGTM but can we wait until next week to merge it? One of our PMs pointed out to me that the 1.7 announcement will be the first time a lot of people hear about the deprecation. A couple more days without any major concerns being raised should give us more confidence that we won't cause significant pain for users by removing it in 1.8.

@deads2k
Copy link
Contributor Author

deads2k commented Jun 30, 2017

LGTM but can we wait until next week to merge it?

Sure. The bad behavior of TPRs and finalizers is blocking generic GC for discovered resources, but waiting until next week won't make or break it.

@deads2k deads2k force-pushed the tpr-17-delete-01 branch from 1408db4 to eeb4e04 Compare June 30, 2017 19:39
@deads2k deads2k force-pushed the tpr-17-delete-01 branch from eeb4e04 to 3ee458d Compare July 3, 2017 15:26
@k8s-github-robot k8s-github-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jul 5, 2017
@deads2k deads2k added release-note-none Denotes a PR that doesn't merit a release note. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 5, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Jul 5, 2017

just generated changes in api

@deads2k deads2k added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2017
@sttts
Copy link
Contributor

sttts commented Jul 5, 2017

lgtm

@deads2k
Copy link
Contributor Author

deads2k commented Jul 5, 2017

LGTM but can we wait until next week to merge it?

Issue has been open over a week. Going ahead with this now.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48480, 48353)

@k8s-github-robot k8s-github-robot merged commit c10cc3d into kubernetes:master Jul 5, 2017
@enisoc enisoc added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 7, 2017
@enisoc enisoc mentioned this pull request Jul 7, 2017
Closed
@deads2k deads2k deleted the tpr-17-delete-01 branch August 3, 2017 20:10
@xiangpengzhao xiangpengzhao mentioned this pull request Aug 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sttts sttts

@enisoc enisoc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deads2k @k8s-github-robot @enisoc @sttts @k8s-ci-robot