clientgo/examples/out-of-cluster: add instructions #46134
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/M
|
/release-note-none |
k8s-ci-robot
added
release-note-none
|
/assign @sttts |
| @@ -0,0 +1,34 @@ | |||
| # Authenticating outside the cluster | |||
|
|
|||
| This example shows you how to autenticate to the Kubernetes API from an | |||
There was a problem hiding this comment.
s/autenticate/authenticate
| There are 3 pods in the cluster | ||
| ... | ||
|
|
||
| Press <kbd>Ctrl<kbd>+<kbd>C<kbd> to quit this application. |
There was a problem hiding this comment.
the kbd is not rendered correctly on my screen :(
There was a problem hiding this comment.
Likely because I forgot to close the tag. Fixed.
| Press <kbd>Ctrl<kbd>+<kbd>C<kbd> to quit this application. | ||
|
|
||
| > **Note:** You can use the `-kubeconfig` option to use a different config file. By default | ||
| this program picks up the default file used by kubectl (when KUBE_CONFIG |
There was a problem hiding this comment.
How about let the program first try getting the KUBE_CONFIG, if empty, try the home_dir/.kube/config, if still empty, fail and prompt the user to specify kubeconfig?
There was a problem hiding this comment.
Do you think it's valuable to have KUBE_CONFIG in api client programs? I assumed it's specifically for KUBE_CONFIG. Maybe we should have an util in client-go that discovers it first from KUBE_CONFIG and then from $HOME/.kube/config. We could use that in other samples, too.
There was a problem hiding this comment.
You mean you assumed it's specifically for kubectl?
Actually I checked the source code of kubectl, it seems it's not parsing $KUBE_CONFIG or $KUBECONFIG.
There was a problem hiding this comment.
@caesarxuchao turns out this is called $KUBECONFIG and it is recognized by kubectl. https://kubernetes.io/docs/tasks/administer-cluster/share-configuration/
|
@caesarxuchao PTAL again and let me know if you have any comments. it looks like the tests are hitting some flakes. |
| kubeconfig := flag.String("kubeconfig", "./config", "absolute path to the kubeconfig file") | ||
| home := homeDir() | ||
| var kubeconfig *string | ||
| if home == "" { |
There was a problem hiding this comment.
nit: if home := homeDir(); home != "" {
|
One nit. Lgtm otherwise. Please squash. |
ahmetb
force-pushed
the
clientgo-examples/out-of-cluster
branch
from
968a9be to
621d950
Compare
|
@sttts done. thanks for reviewing. |
Adding instructions for out-of-cluster example and making it work without specifying the -kubeconfig argument if the home directory can be inferred. This is part of the body of work improving the client library samples. Signed-off-by: Ahmet Alp Balkan <[email protected]>
ahmetb
force-pushed
the
clientgo-examples/out-of-cluster
branch
from
621d950 to
e59f05f
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, caesarxuchao
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
lgtm
k8s-github-robot
added
the
approved
|
Thanks, @ahmetb! |
|
Automatic merge from submit-queue (batch tested with PRs 44061, 46614, 46419, 46628, 46134) |
Adding instructions for out-of-cluster example and making it work without
specifying the -kubeconfig argument if the home directory can be inferred.
This is part of the body of work improving the client library samples.
Signed-off-by: Ahmet Alp Balkan [email protected]