Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oidc auth plugin not to override the Auth header if it's already exits #45529

Merged
merged 1 commit into from
May 9, 2017
Merged

oidc auth plugin not to override the Auth header if it's already exits #45529

merged 1 commit into from
May 9, 2017

Conversation

wanghaoran1988
Copy link
Contributor

@wanghaoran1988 wanghaoran1988 commented May 9, 2017 •
edited
Loading

What this PR does / why we need it:
oidc auth client plugin should not override the Authorization header if it's already exits.
Which issue this PR fixes :
fix oidc auth plugin override the Authorization header
Special notes for your reviewer:

Release note:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 9, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 9, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @wanghaoran1988. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 9, 2017
@wanghaoran1988
Copy link
Contributor Author

@liggitt @ericchiang PTAL

@ericchiang
Copy link
Contributor

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2017
@ericchiang
Copy link
Contributor

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 9, 2017
@ericchiang
Copy link
Contributor

@wanghaoran1988 strictly speaking this doesn't fix #44476, it just updates it since it doesn't fix the google client auth plugin.

@wanghaoran1988
Copy link
Contributor Author

@ericchiang Oh, seems this just fixed the oidc auth plugin, for gcp auth plugin, the Auth header is override by the tokenSource.

@liggitt liggitt added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 9, 2017
@liggitt
Copy link
Member

liggitt commented May 9, 2017

edited the description to avoid closing the tracking issue

@wanghaoran1988
Copy link
Contributor Author

@liggitt Done

@ericchiang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ericchiang, wanghaoran1988

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 52e8d6b into kubernetes:master May 9, 2017
@ericchiang ericchiang mentioned this pull request May 10, 2017
Merged
@liggitt liggitt mentioned this pull request May 15, 2017
Closed
@deads2k deads2k mentioned this pull request Jun 1, 2017
Merged
@wanghaoran1988 wanghaoran1988 deleted the fix_issue_44476 branch November 22, 2017 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ericchiang ericchiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wanghaoran1988 @k8s-reviewable @k8s-ci-robot @ericchiang @liggitt @k8s-github-robot