This change is 

cc @derekwaynecarr @sjenning

@k8s-bot unit test this

@k8s-bot kops aws e2e test this

/release-note-none

Seems ok to me. @dchen1107 @yujuhong @vishh @kubernetes/sig-node-pr-reviews wdyt?

Not 100% clear - this is to ensure we get a stronger signal to debug flakes? or it's to make flakes go away? Or a flaw in the tests that they have timeouts with force deletion?

I thought it was to make flakes go away by waiting longer for pods to be deleted. If that's not the case, I would like to know the purpose.

@smarterclayton not a flaw in the tests. This change has two motivations:

• Make flakes go away by increasing timeouts (for some tests, which currently have low timeouts)
• Make timeouts consistent across tests.

Making timeouts consistent should prevent needing to update each timeout individually as I have in the past: #42661 #41157

Ok, I just wanted to make sure this wasn't "we have bugs in cleanup of pods when short termination deadlines are set".

/approve

/lgtm

The idea SGTM; didn't review the PR.

@k8s-bot gce etcd3 e2e test this

@dashpole could you let this pull also fix the tests reported in #42646 as well? Let me know if you prefer me sending a PR based on this one.

@caesarxuchao just saw this. Working on adding it now... If i dont make it before this merges then Ill just open another PR

@caesarxuchao @ncdc I updated this PR to include the timeouts in test/e2e/common/pods.go and test/e2e/generated_clientset.go. PTAL

Changes in test/e2e/generated_clientset.go lgtm. Thanks.

See #42776. Pod deletion shouldn't normally take this long.

I agree that they should not normally take this long. Ideally, we should have separate tests for pod deletion latency. I plan to add these in the near future. However, I still think having uniform pod deletion timeouts is useful.

Assuming #42779 merges, which fixes deletion problems (#42685, #42776), this PR is no longer required for 1.6. It is still useful, but it is not urgent.

I agree that they should not normally take this long. Ideally, we should have separate tests for pod deletion latency. I plan to add these in the near future. However, I still think having uniform pod deletion timeouts is useful.

Agreed. Didn't mean to imply that this PR is no longer needed. I think it'd still be good to get this in for 1.6 as part of the test cleanup.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: dashpole, ncdc, smarterclayton, yujuhong

Needs approval from an approver in each of these OWNERS Files:

• test/OWNERS [ncdc,smarterclayton]

We suggest the following people:
cc @liggitt
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

Automatic merge from submit-queue (batch tested with PRs 42734, 42745, 42758, 42814, 42694)

@smarterclayton RE: #42734 (comment): you did smell a real issue here :-)